address some review comments
diff --git a/dwds/lib/src/dwds_vm_client.dart b/dwds/lib/src/dwds_vm_client.dart index 716ce0f..33f4731 100644 --- a/dwds/lib/src/dwds_vm_client.dart +++ b/dwds/lib/src/dwds_vm_client.dart
@@ -484,7 +484,7 @@ } }); }); - logger.info('Issuing \$dartHotRestartBeginDwds request'); + logger.info('Issuing \$dartHotRestartBeginDwds request.'); final remoteObject = await chromeProxyService.inspector.jsEvaluate( '\$dartHotRestartBeginDwds(\'$runId\', $pauseIsolatesOnStart);', awaitPromise: true,
diff --git a/dwds/test/frontend_server_common/bootstrap.dart b/dwds/test/frontend_server_common/bootstrap.dart index 143cbd4..c49a236 100644 --- a/dwds/test/frontend_server_common/bootstrap.dart +++ b/dwds/test/frontend_server_common/bootstrap.dart
@@ -496,7 +496,6 @@ if (!window.\$dartReloadModifiedModules) { window.\$dartReloadModifiedModules = (function(filesToReload, appName) { return new Promise(function(resolve) { - let requestedScripts = []; function callback() { resolve(filesToReload); }
diff --git a/dwds/web/reloader/ddc_library_bundle_restarter.dart b/dwds/web/reloader/ddc_library_bundle_restarter.dart index 0e431d8..630890b 100644 --- a/dwds/web/reloader/ddc_library_bundle_restarter.dart +++ b/dwds/web/reloader/ddc_library_bundle_restarter.dart
@@ -21,7 +21,7 @@ external JSPromise<JSArray<JSObject>> hotRestartBegin([ JSArray<JSObject>? reloadedSources, ]); - external JSAny? hotRestartEnd(); + external void hotRestartEnd(); external JSPromise<JSAny?> hotReload( JSArray<JSString> filesToLoad,
diff --git a/dwds/web/reloader/restarter.dart b/dwds/web/reloader/restarter.dart index 01a93f4..1810cca 100644 --- a/dwds/web/reloader/restarter.dart +++ b/dwds/web/reloader/restarter.dart
@@ -5,6 +5,13 @@ import 'dart:js_interop'; /// A Restarter that supports a hot restart over two phases. +/// +/// The APIs here should be used in place of [Restarter.restart]. +/// +/// This is a temporary interface that is only useful while there are +/// `Restarter`s that don't use the two phase restart. +// TODO(nshahan): Move these members into `Restarter` when all have been +// migrated to the two phase restart. abstract class TwoPhaseRestarter implements Restarter { /// Starts a hot restart operation. ///