Remove dead code for reading events from console (#1483)
The `'dart.developer.registerExtension'` and `'dart.developer.postEvent'`
events from the chrome console. These messages haven't been written to the
console since dwds v11.1.0 and Dart SDK v2.14.0.
Fixes: https://github.com/dart-lang/webdev/issues/1342
diff --git a/dwds/CHANGELOG.md b/dwds/CHANGELOG.md
index 843f73a..3726abf 100644
--- a/dwds/CHANGELOG.md
+++ b/dwds/CHANGELOG.md
@@ -8,6 +8,9 @@
- Fix a bug where `dartEmitDebugEvents` was set as a `String` instead of `bool`
in the injected client.
- Emit a warning instead of crashing on missing `libraries.json`.
+- Remove dead code for reading `'dart.developer.registerExtension'` and
+ `'dart.developer.postEvent'` events from the chrome console. These messages
+ haven't been written to the console since dwds v11.1.0 and Dart SDK v2.14.0.
**Breaking changes:**
diff --git a/dwds/lib/src/services/chrome_proxy_service.dart b/dwds/lib/src/services/chrome_proxy_service.dart
index 8f50bd4..f32ecc1 100644
--- a/dwds/lib/src/services/chrome_proxy_service.dart
+++ b/dwds/lib/src/services/chrome_proxy_service.dart
@@ -876,32 +876,9 @@
if (isolateRef.id != isolate.id) return;
var firstArgValue = event.args[0].value as String;
- // TODO(grouma) - Remove when the min SDK has updated to migrate users
- // over to the injected client communication approach.
+ // TODO(nshahan) - Migrate 'inspect' and 'log' events to the injected
+ // client communication approach as well?
switch (firstArgValue) {
- case 'dart.developer.registerExtension':
- var service = event.args[1].value as String;
- isolate.extensionRPCs.add(service);
- _streamNotify(
- EventStreams.kIsolate,
- Event(
- kind: EventKind.kServiceExtensionAdded,
- timestamp: DateTime.now().millisecondsSinceEpoch,
- isolate: isolateRef)
- ..extensionRPC = service);
- break;
- case 'dart.developer.postEvent':
- _streamNotify(
- EventStreams.kExtension,
- Event(
- kind: EventKind.kExtension,
- timestamp: DateTime.now().millisecondsSinceEpoch,
- isolate: isolateRef)
- ..extensionKind = event.args[1].value as String
- ..extensionData = ExtensionData.parse(
- jsonDecode(event.args[2].value as String)
- as Map<String, dynamic>));
- break;
case 'dart.developer.inspect':
// All inspected objects should be real objects.
if (event.args[1].type != 'object') break;
