Remove dead code updating opType

These assignments don't impact any of the following code because we
no longer reference these fields.

Change-Id: I83e294c2dc7f4487f8fe9b2b284c9e6eaf050f1e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368040
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart b/pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart
index 72dc125..7fffbf7 100644
--- a/pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart
+++ b/pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart
@@ -2556,8 +2556,6 @@
       if (pattern is ConstantPattern) {
         if (pattern.expression case SimpleIdentifier identifier) {
           if (!identifier.isSynthetic && offset < identifier.offset) {
-            state.request.opType.includeConstructorSuggestions = false;
-            state.request.opType.mustBeConst = true;
             declarationHelper(
               mustBeType: true,
             ).addLexicalDeclarations(node);
@@ -2570,8 +2568,6 @@
       // The user want a type for incomplete WildcardPattern.
       if (pattern is WildcardPattern) {
         if (offset < pattern.name.offset) {
-          state.request.opType.includeConstructorSuggestions = false;
-          state.request.opType.mustBeConst = true;
           declarationHelper(
             mustBeType: true,
           ).addLexicalDeclarations(node);
@@ -2599,17 +2595,14 @@
         switch (type.parent) {
           case DeclaredVariablePattern():
             //collector.completionLocation = 'DeclaredVariablePattern_type';
-            state.request.opType.includeConstructorSuggestions = false;
             type.accept(this);
             return;
           case ObjectPattern():
             collector.completionLocation = 'ObjectPattern_type';
-            state.request.opType.includeConstructorSuggestions = false;
             type.accept(this);
             return;
           case WildcardPattern():
             collector.completionLocation = 'WildcardPattern_type';
-            state.request.opType.includeConstructorSuggestions = false;
             type.accept(this);
             return;
         }
@@ -3351,8 +3344,6 @@
       if (pattern is ConstantPattern) {
         if (pattern.expression case SimpleIdentifier identifier) {
           if (!identifier.isSynthetic && offset < identifier.offset) {
-            state.request.opType.includeConstructorSuggestions = false;
-            state.request.opType.mustBeConst = true;
             declarationHelper(
               mustBeType: true,
             ).addLexicalDeclarations(node);
@@ -3364,8 +3355,6 @@
       // The user wants a type for incomplete WildcardPattern.
       if (pattern is WildcardPattern) {
         if (offset < pattern.name.offset) {
-          state.request.opType.includeConstructorSuggestions = false;
-          state.request.opType.mustBeConst = true;
           declarationHelper(
             mustBeType: true,
           ).addLexicalDeclarations(node);
@@ -3384,8 +3373,6 @@
           keywordHelper.addPatternKeywords();
           // TODO(scheglov): Actually we need constructors, but only const.
           // And not-yet imported contributors does not work well yet.
-          state.request.opType.includeConstructorSuggestions = false;
-          state.request.opType.mustBeConst = true;
           declarationHelper(
             mustBeNonVoid: true,
           ).addLexicalDeclarations(node);
@@ -3400,17 +3387,14 @@
       switch (type.parent) {
         case DeclaredVariablePattern():
           collector.completionLocation = 'DeclaredVariablePattern_type';
-          state.request.opType.includeConstructorSuggestions = false;
           type.accept(this);
           return;
         case ObjectPattern():
           collector.completionLocation = 'ObjectPattern_type';
-          state.request.opType.includeConstructorSuggestions = false;
           type.accept(this);
           return;
         case WildcardPattern():
           collector.completionLocation = 'WildcardPattern_type';
-          state.request.opType.includeConstructorSuggestions = false;
           type.accept(this);
           return;
       }