Drop unused lastPhase and beforeRcDataPhase fields (#137)
These fields are unused in both this library and the python library from
which it was transliterated. The `lastPhase` was later named to
`originalPhase` but not all references were cleaned up which leaves one
remaining assignment to null. `beforeRcDataPhase` was unused in the
commit which introduced it and never assigned an interesting value or
read the field.
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 615a09f..e294c41 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,8 @@
## 0.15.0-dev
+- Drop `HtmlParser.lastPhase` and `HtmlParser.beforeRcDataPhase`. These fields
+ never had a value other than `null`.
+
## 0.14.0+4
- Fix a bug parsing bad HTML where a 'button' end tag needs to close other
diff --git a/lib/parser.dart b/lib/parser.dart
index 363aa23..00c1562 100644
--- a/lib/parser.dart
+++ b/lib/parser.dart
@@ -93,12 +93,8 @@
Phase phase;
- Phase lastPhase;
-
Phase originalPhase;
- Phase beforeRCDataPhase;
-
bool framesetOK;
// These fields hold the different phase singletons. At any given time one
@@ -252,8 +248,6 @@
phase = _initialPhase;
}
- lastPhase = null;
- beforeRCDataPhase = null;
framesetOK = true;
}
