Dont show warnings by default (#365)
diff --git a/pkgs/firehose/CHANGELOG.md b/pkgs/firehose/CHANGELOG.md index 151e54a..0ee7b55 100644 --- a/pkgs/firehose/CHANGELOG.md +++ b/pkgs/firehose/CHANGELOG.md
@@ -1,3 +1,7 @@ +## 0.12.1-wip + +- Make the PR health output less verbose by collapsing warnings by default. + ## 0.12.0 - Make the location of the health.yaml workflow configurable.
diff --git a/pkgs/firehose/lib/src/health/health.dart b/pkgs/firehose/lib/src/health/health.dart index 7506ae3..17e51b1 100644 --- a/pkgs/firehose/lib/src/health/health.dart +++ b/pkgs/firehose/lib/src/health/health.dart
@@ -17,7 +17,7 @@ import 'coverage.dart'; import 'license.dart'; -const apiToolHash = '7422ff6481101765899ae37495ce667acb400589'; +const apiToolHash = '4377249ec08f0fa508298077eae236f24f315e19'; enum Check { license('License Headers', 'license'), @@ -506,17 +506,20 @@ final String markdownSummary; if (result.markdown != null) { var markdown = result.markdown; - var isWorseThanInfo = result.severity.index >= Severity.warning.index; + var expand = switch (result.severity) { + Severity.success || Severity.info || Severity.warning => false, + Severity.error => true, + }; markdownSummary = ''' -<details${isWorseThanInfo ? ' open' : ''}> +<details${expand ? ' open' : ''}> <summary> <strong>${check.tag}</strong> ${result.severity.emoji} </summary> $markdown -${isWorseThanInfo ? 'This check can be disabled by tagging the PR with `skip-${result.check.displayName}-check`.' : ''} +This check can be disabled by tagging the PR with `skip-${result.check.displayName}-check`. </details> ''';
diff --git a/pkgs/firehose/pubspec.yaml b/pkgs/firehose/pubspec.yaml index dbe943c..6c4f008 100644 --- a/pkgs/firehose/pubspec.yaml +++ b/pkgs/firehose/pubspec.yaml
@@ -1,6 +1,6 @@ name: firehose description: A tool to automate publishing of Pub packages from GitHub actions. -version: 0.12.0 +version: 0.12.1-wip repository: https://github.com/dart-lang/ecosystem/tree/main/pkgs/firehose environment:
diff --git a/pkgs/firehose/test_data/golden/comment_breaking.md b/pkgs/firehose/test_data/golden/comment_breaking.md index 84aabe0..b6ca7d8 100644 --- a/pkgs/firehose/test_data/golden/comment_breaking.md +++ b/pkgs/firehose/test_data/golden/comment_breaking.md
@@ -1,4 +1,4 @@ -<details open> +<details> <summary> <strong>Breaking changes</strong> :warning: </summary>
diff --git a/pkgs/firehose/test_data/golden/comment_breaking_healthchanged.md b/pkgs/firehose/test_data/golden/comment_breaking_healthchanged.md index 62ca959..3ee63bb 100644 --- a/pkgs/firehose/test_data/golden/comment_breaking_healthchanged.md +++ b/pkgs/firehose/test_data/golden/comment_breaking_healthchanged.md
@@ -1,4 +1,4 @@ -<details open> +<details> <summary> <strong>Breaking changes</strong> :warning: </summary>
diff --git a/pkgs/firehose/test_data/golden/comment_breaking_ignore_package.md b/pkgs/firehose/test_data/golden/comment_breaking_ignore_package.md index 59fda74..24d59fb 100644 --- a/pkgs/firehose/test_data/golden/comment_breaking_ignore_package.md +++ b/pkgs/firehose/test_data/golden/comment_breaking_ignore_package.md
@@ -1,4 +1,4 @@ -<details open> +<details> <summary> <strong>Breaking changes</strong> :warning: </summary>
diff --git a/pkgs/firehose/test_data/golden/comment_coverage.md b/pkgs/firehose/test_data/golden/comment_coverage.md index 52d81ee..1666998 100644 --- a/pkgs/firehose/test_data/golden/comment_coverage.md +++ b/pkgs/firehose/test_data/golden/comment_coverage.md
@@ -1,4 +1,4 @@ -<details open> +<details> <summary> <strong>Coverage</strong> :warning: </summary>
diff --git a/pkgs/firehose/test_data/golden/comment_coverage_healthchanged.md b/pkgs/firehose/test_data/golden/comment_coverage_healthchanged.md index 5de5ebe..aed1009 100644 --- a/pkgs/firehose/test_data/golden/comment_coverage_healthchanged.md +++ b/pkgs/firehose/test_data/golden/comment_coverage_healthchanged.md
@@ -1,4 +1,4 @@ -<details open> +<details> <summary> <strong>Coverage</strong> :warning: </summary>
diff --git a/pkgs/firehose/test_data/golden/comment_coverage_ignore_package.md b/pkgs/firehose/test_data/golden/comment_coverage_ignore_package.md index 4613733..1b09c71 100644 --- a/pkgs/firehose/test_data/golden/comment_coverage_ignore_package.md +++ b/pkgs/firehose/test_data/golden/comment_coverage_ignore_package.md
@@ -1,4 +1,4 @@ -<details open> +<details> <summary> <strong>Coverage</strong> :warning: </summary>
diff --git a/pkgs/firehose/test_data/golden/comment_leaking.md b/pkgs/firehose/test_data/golden/comment_leaking.md index 4711c9c..7d88936 100644 --- a/pkgs/firehose/test_data/golden/comment_leaking.md +++ b/pkgs/firehose/test_data/golden/comment_leaking.md
@@ -1,4 +1,4 @@ -<details open> +<details> <summary> <strong>API leaks</strong> :warning: </summary>
diff --git a/pkgs/firehose/test_data/golden/comment_leaking_healthchanged.md b/pkgs/firehose/test_data/golden/comment_leaking_healthchanged.md index 4711c9c..7d88936 100644 --- a/pkgs/firehose/test_data/golden/comment_leaking_healthchanged.md +++ b/pkgs/firehose/test_data/golden/comment_leaking_healthchanged.md
@@ -1,4 +1,4 @@ -<details open> +<details> <summary> <strong>API leaks</strong> :warning: </summary>
diff --git a/pkgs/firehose/test_data/golden/comment_leaking_ignore_package.md b/pkgs/firehose/test_data/golden/comment_leaking_ignore_package.md index 4711c9c..7d88936 100644 --- a/pkgs/firehose/test_data/golden/comment_leaking_ignore_package.md +++ b/pkgs/firehose/test_data/golden/comment_leaking_ignore_package.md
@@ -1,4 +1,4 @@ -<details open> +<details> <summary> <strong>API leaks</strong> :warning: </summary>