test(firehose): use hasLength, containsPair, and isFalse (#477)

pkgs/firehose/test/firehose_test.dart

diff --git a/pkgs/firehose/test/firehose_test.dart b/pkgs/firehose/test/firehose_test.dart
index ef2ec51..608644a 100644
--- a/pkgs/firehose/test/firehose_test.dart
+++ b/pkgs/firehose/test/firehose_test.dart
@@ -37,7 +37,7 @@
         ..addResult(Result.info(pkgB, Result.alreadyPublishedMessage,
             isAffected: true));
 
-      expect(results.visibleResults.length, 2);
+      expect(results.visibleResults, hasLength(2));
       expect(results.hiddenResults, isEmpty);
 
       final markdown = results.describeAsMarkdown(withTag: false);
@@ -53,7 +53,7 @@
             Result.success(pkgA, '**ready to publish**', isAffected: false))
         ..addResult(Result.fail(pkgB, 'version mismatch', isAffected: false));
 
-      expect(results.visibleResults.length, 2);
+      expect(results.visibleResults, hasLength(2));
       expect(results.hiddenResults, isEmpty);
 
       final markdown = results.describeAsMarkdown(withTag: false);
@@ -72,8 +72,8 @@
         ..addResult(Result.info(pkgE, Result.alreadyPublishedMessage,
             isAffected: false));
 
-      expect(results.visibleResults.length, 2);
-      expect(results.hiddenResults.length, 3);
+      expect(results.visibleResults, hasLength(2));
+      expect(results.hiddenResults, hasLength(3));
 
       final markdown = results.describeAsMarkdown(withTag: false);
       expect(markdown, contains('| package:pkg_1 |'));
@@ -104,7 +104,7 @@
         ..addResult(Result.info(pkgB, Result.wipMessage, isAffected: false));
 
       expect(results.visibleResults, isEmpty);
-      expect(results.hiddenResults.length, 2);
+      expect(results.hiddenResults, hasLength(2));
 
       final markdown = results.describeAsMarkdown(withTag: false);
       expect(

pkgs/firehose/test/repo_test.dart

diff --git a/pkgs/firehose/test/repo_test.dart b/pkgs/firehose/test/repo_test.dart
index b8e0011..33c191c 100644
--- a/pkgs/firehose/test/repo_test.dart
+++ b/pkgs/firehose/test/repo_test.dart
@@ -33,7 +33,7 @@
 
     test('isSinglePackageRepo', () {
       final result = packages.isSinglePackageRepo;
-      expect(result, false);
+      expect(result, isFalse);
     });
 
     test('locatePackages', () {
@@ -62,10 +62,21 @@
       expect(releaseUri.path, '/${github.repoSlug}/releases/new');
 
       final queryParams = releaseUri.queryParameters;
-      expect(queryParams['tag'], packages.calculateRepoTag(package));
-      expect(queryParams['title'],
-          allOf(contains(package.name), contains(package.version.toString())));
-      expect(queryParams['body'], package.changelog.describeLatestChanges);
+      expect(
+        queryParams,
+        containsPair('tag', packages.calculateRepoTag(package)),
+      );
+      expect(
+        queryParams,
+        containsPair(
+          'title',
+          allOf(contains(package.name), contains(package.version.toString())),
+        ),
+      );
+      expect(
+        queryParams,
+        containsPair('body', package.changelog.describeLatestChanges),
+      );
     });
 
     test('github release link with custom prefix', () {
@@ -82,10 +93,13 @@
 
       final queryParams = releaseUri.queryParameters;
       expect(
-        queryParams['tag'],
-        packages.calculateRepoTag(package, tagPrefix: ''),
+        queryParams,
+        containsPair('tag', packages.calculateRepoTag(package, tagPrefix: '')),
       );
-      expect(queryParams['tag'], '${package.name}-${package.pubspec.version}');
+      expect(
+        queryParams,
+        containsPair('tag', '${package.name}-${package.pubspec.version}'),
+      );
     });
   });