[results feed] Update the protobuf definition file
Change-Id: I5d4819fc9871e70989ff7e78c6f9486dcb3a7479
Reviewed-on: https://dart-review.googlesource.com/c/dart_ci/+/136638
Reviewed-by: Alexander Thomas <athom@google.com>
diff --git a/results_feed/doc/results_feed.proto b/results_feed/doc/results_feed.proto
index fdb82f0..a97e2fa 100644
--- a/results_feed/doc/results_feed.proto
+++ b/results_feed/doc/results_feed.proto
@@ -37,12 +37,28 @@
// Commits to sdk/master are indexed consecutively in the table 'commits'.
int32 blamelist_start_index = 7;
int32 blamelist_end_index = 8; // Inclusive: this commit is in the blamelist.
+ reserved 9; // Unused
// Optional: The index of a the commit that is responsible for these changes.
// Chosen by a user in the results feed UI.
int32 pinned_index = 10;
+ reserved 11, 12; // Used in TryResult
bool approved = 13; // May be missing in older records, interpreted as false.
+
+ // Configurations where this result is the latest change to
+ // the result of this test are considered active. If a new change comes in,
+ // changing the result of this test on a configuration, that configuration is
+ // removed from the set active_configurations.
+ // The 'active' and 'active_configurations' fields are present only if there
+ // are some active configurations remaining.
+
+ // Present, and true, if this result is still active on some configuration.
+ bool active = 14;
+
+ // Present only if nonempty. The configurations on which this is
+ // the latest change to this test's result.
+ repeated string active_configurations = 15;
}
// Similar to a Result message, but representing results from a try builder.
@@ -94,14 +110,15 @@
string id = 1;
int32 build_number = 2;
string builder = 3;
- int32 review = 9;
- int32 patchset = 10;
- string buildbucket_id = 11;
+ reserved 4;
int32 num_chunks = 5; // The number of chunks of results for this build.
int32 processed_chunks = 6; // The number of results chunks received.
// True if no new unapproved failures have been received.
bool success = 7;
bool completed = 8; // True if all chunks have been received.
+ int32 review = 9;
+ int32 patchset = 10;
+ string buildbucket_id = 11;
}
message Commit {
@@ -156,17 +173,14 @@
string id = 1;
// The email address of the user who made this comment/approval.
- string user = 2;
+ string author = 2;
// The time that the comment/approval was entered
google.protobuf.Timestamp created = 3;
// The text of the comment (optional if link is present).
string comment = 4;
-
- // The URL of a link to an issue (optional).
- string link = 5;
-
+ reserved 5;
// If approved is true, this comment approves the linked tests
// If approved is false, it removes any earlier approvals on these tests
// If the field is missing, it does not change the current approval status
@@ -178,13 +192,9 @@
// fields will be missing.
repeated string results = 7;
repeated string try_results = 8;
-
- // The base comment, if this comment is a reply to a previous comment.
- // All comments link to the beginning of their reply chain, not to the
- // previous comment, and are only ordered by timestamp.
- string base_comment = 9;
-
+ reserved 9;
// These are copies of the fields in the results this comment refers to.
+ // A comment may belong to both a review and to the commit landing the review.
// These are the fields from a Result message
int32 blamelist_start_index = 10;
int32 blamelist_end_index = 11;
diff --git a/results_feed/pubspec.lock b/results_feed/pubspec.lock
index c5b977c..11104f0 100644
--- a/results_feed/pubspec.lock
+++ b/results_feed/pubspec.lock
@@ -450,7 +450,7 @@
source: hosted
version: "1.4.0"
protobuf:
- dependency: transitive
+ dependency: "direct main"
description:
name: protobuf
url: "https://pub.dartlang.org"
@@ -688,4 +688,4 @@
source: hosted
version: "2.2.0"
sdks:
- dart: ">=2.7.0-dev <=2.8.0-dev.9.0"
+ dart: ">=2.7.0-dev <=2.8.0-dev.11.0"
diff --git a/results_feed/pubspec.yaml b/results_feed/pubspec.yaml
index 622032c..5ffd786 100644
--- a/results_feed/pubspec.yaml
+++ b/results_feed/pubspec.yaml
@@ -13,6 +13,7 @@
firebase: ^7.0.0
http: ^0.12.0
intl: ^0.15.0
+ protobuf: ">=0.13.6"
quiver: ^2.1.0
service_worker: ^0.2.2
