Actually skip on windows (#478)
* Actually skip on windows
* fix final lints
diff --git a/.travis.yml b/.travis.yml
index c4d89e0..b30ad19 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -42,12 +42,12 @@
env: PKGS="dwds"
script: ./tool/travis.sh test_0
- stage: unit_test
- name: "SDK: 2.3.2-dev.0.1; PKG: webdev; TASKS: `pub run test -j 1 --run-skipped`"
+ name: "SDK: 2.3.2-dev.0.1; PKG: webdev; TASKS: `pub run test -j 1`"
dart: "2.3.2-dev.0.1"
env: PKGS="webdev"
script: ./tool/travis.sh test_1
- stage: unit_test
- name: "SDK: dev; PKG: webdev; TASKS: `pub run test -j 1 --run-skipped`"
+ name: "SDK: dev; PKG: webdev; TASKS: `pub run test -j 1`"
dart: dev
env: PKGS="webdev"
script: ./tool/travis.sh test_1
diff --git a/appveyor.yml b/appveyor.yml
index b3a8685..9aea605 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -15,7 +15,7 @@
build: off
test_script:
- - C:\tools\dart-sdk\bin\pub.bat run test -j 1 --run-skipped
+ - C:\tools\dart-sdk\bin\pub.bat run test -j 1
cache:
- C:\Users\appveyor\AppData\Roaming\Pub\Cache
diff --git a/dwds/lib/src/debugger.dart b/dwds/lib/src/debugger.dart
index 27e8186..5620ed4 100644
--- a/dwds/lib/src/debugger.dart
+++ b/dwds/lib/src/debugger.dart
@@ -24,7 +24,7 @@
};
class Debugger extends Domain {
- WipConnection _tabConnection;
+ final WipConnection _tabConnection;
final AssetHandler _assetHandler;
final StreamNotify _streamNotify;
@@ -49,7 +49,7 @@
/// The breakpoints we have set so far, indexable by either
/// Dart or JS ID.
- _Breakpoints _breakpoints;
+ final _Breakpoints _breakpoints;
/// Allocates Dart breakpoint IDs
int _nextBreakpointId = 1;
diff --git a/dwds/lib/src/domain.dart b/dwds/lib/src/domain.dart
index 79dff34..1133a1d 100644
--- a/dwds/lib/src/domain.dart
+++ b/dwds/lib/src/domain.dart
@@ -12,7 +12,7 @@
///
/// Subclasses should call the super constructor with the AppInspectorProvider.
abstract class Domain {
- AppInspectorProvider _appInspectorProvider;
+ final AppInspectorProvider _appInspectorProvider;
Domain(this._appInspectorProvider);
diff --git a/tool/travis.sh b/tool/travis.sh
index 65bc388..4317be7 100755
--- a/tool/travis.sh
+++ b/tool/travis.sh
@@ -39,8 +39,8 @@
pub run test || EXIT_CODE=$?
;;
test_1)
- echo 'pub run test -j 1 --run-skipped'
- pub run test -j 1 --run-skipped || EXIT_CODE=$?
+ echo 'pub run test -j 1'
+ pub run test -j 1 || EXIT_CODE=$?
;;
*)
echo -e "\033[31mNot expecting TASK '${TASK}'. Error!\033[0m"
diff --git a/webdev/dart_test.yaml b/webdev/dart_test.yaml
index 518074d..ca66887 100644
--- a/webdev/dart_test.yaml
+++ b/webdev/dart_test.yaml
@@ -1,7 +1 @@
-tags:
- presubmit-only:
- skip: "Should only be run during presubmit"
- webdriver:
- skip: "Should only be run during presubmit"
-
retry: 3
diff --git a/webdev/mono_pkg.yaml b/webdev/mono_pkg.yaml
index f0c1b85..ad5a360 100644
--- a/webdev/mono_pkg.yaml
+++ b/webdev/mono_pkg.yaml
@@ -13,4 +13,4 @@
- dartanalyzer: --fatal-warnings .
dart: [2.3.2-dev.0.1]
- unit_test:
- - test: -j 1 --run-skipped
+ - test: -j 1
diff --git a/webdev/test/build/ensure_build_test.dart b/webdev/test/build/ensure_build_test.dart
index d3466e9..77d818b 100644
--- a/webdev/test/build/ensure_build_test.dart
+++ b/webdev/test/build/ensure_build_test.dart
@@ -2,8 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-@Tags(['presubmit-only'])
-
import 'package:build_verify/build_verify.dart';
import 'package:test/test.dart';
diff --git a/webdev/test/daemon/app_domain_test.dart b/webdev/test/daemon/app_domain_test.dart
index ef5af2b..7772b10 100644
--- a/webdev/test/daemon/app_domain_test.dart
+++ b/webdev/test/daemon/app_domain_test.dart
@@ -142,5 +142,5 @@
expect(await webdev.exitCode, equals(0));
});
});
- }, tags: ['webdriver']);
+ });
}
diff --git a/webdev/test/daemon/daemon_domain_test.dart b/webdev/test/daemon/daemon_domain_test.dart
index f29741e..07916e1 100644
--- a/webdev/test/daemon/daemon_domain_test.dart
+++ b/webdev/test/daemon/daemon_domain_test.dart
@@ -48,5 +48,5 @@
expect(await webdev.exitCode, equals(0));
});
});
- }, tags: ['webdriver']);
+ });
}
diff --git a/webdev/test/serve/injected/devtools_test.dart b/webdev/test/serve/injected/devtools_test.dart
index b45e234..24c2e12 100644
--- a/webdev/test/serve/injected/devtools_test.dart
+++ b/webdev/test/serve/injected/devtools_test.dart
@@ -3,7 +3,6 @@
// BSD-style license that can be found in the LICENSE file.
@Timeout(Duration(minutes: 5))
-@Tags(['webdriver'])
import 'dart:async';
import 'dart:io';
diff --git a/webdev/test/serve/injected/reload_test.dart b/webdev/test/serve/injected/reload_test.dart
index b2dfa65..d8d1e84 100644
--- a/webdev/test/serve/injected/reload_test.dart
+++ b/webdev/test/serve/injected/reload_test.dart
@@ -114,5 +114,5 @@
await fixture.webdev.kill();
});
- }, tags: ['webdriver']);
+ });
}
diff --git a/webdev/test/serve/screenshot_test.dart b/webdev/test/serve/screenshot_test.dart
index 2884f30..2ccf8ef 100644
--- a/webdev/test/serve/screenshot_test.dart
+++ b/webdev/test/serve/screenshot_test.dart
@@ -3,7 +3,6 @@
// BSD-style license that can be found in the LICENSE file.
@Timeout(Duration(minutes: 1))
-@Tags(['webdriver'])
import 'dart:io';
import 'package:test/test.dart';
