commit e7a671010a97e5740320c0c0cf3cb495d754bbbb
author Jacob MacDonald <jakemac@google.com> Mon Mar 08 19:17:27 2021 -0800
committer GitHub <noreply@github.com> Mon Mar 08 19:17:27 2021 -0800
tree 2f8282f0d1b46751ffa5e715b60a4dc4a2724278
parent 0de7bc909faed3185867f7f1500c428516908c22

fix handling of null remote exception messages (#1455)

pkgs/test_api/CHANGELOG.md

diff --git a/pkgs/test_api/CHANGELOG.md b/pkgs/test_api/CHANGELOG.md
index 180a246..53c6971 100644
--- a/pkgs/test_api/CHANGELOG.md
+++ b/pkgs/test_api/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 0.3.0-dev
+
+* **Breaking** `TestException.message` is now nullable.
+  * Fixes handling of `null` messages in remote exceptions.
+
 ## 0.2.20
 
 * Fix some strong null safety mode errors in the original migration.

pkgs/test_api/lib/src/frontend/expect.dart

diff --git a/pkgs/test_api/lib/src/frontend/expect.dart b/pkgs/test_api/lib/src/frontend/expect.dart
index 3b5b4c6..6659cf1 100644
--- a/pkgs/test_api/lib/src/frontend/expect.dart
+++ b/pkgs/test_api/lib/src/frontend/expect.dart
@@ -11,12 +11,12 @@
 
 /// An exception thrown when a test assertion fails.
 class TestFailure {
-  final String message;
+  final String? message;
 
   TestFailure(this.message);
 
   @override
-  String toString() => message;
+  String toString() => message.toString();
 }
 
 /// The type used for functions that can be used to build up error reports

pkgs/test_api/lib/src/util/remote_exception.dart

diff --git a/pkgs/test_api/lib/src/util/remote_exception.dart b/pkgs/test_api/lib/src/util/remote_exception.dart
index c768ff8..8f2e45a 100644
--- a/pkgs/test_api/lib/src/util/remote_exception.dart
+++ b/pkgs/test_api/lib/src/util/remote_exception.dart
@@ -17,7 +17,7 @@
   ///
   /// If the original exception was a plain string, this will contain that
   /// string.
-  final String message;
+  final String? message;
 
   /// The value of the original exception's `runtimeType.toString()`.
   final String type;
@@ -63,7 +63,7 @@
 
   /// Deserializes the exception portion of [serialized].
   static RemoteException _deserializeException(serialized) {
-    final message = serialized['message'] as String;
+    final message = serialized['message'] as String?;
     final type = serialized['type'] as String;
     final toString = serialized['toString'] as String;
 
@@ -86,6 +86,6 @@
 /// It's important to preserve [TestFailure]-ness, because tests have different
 /// results depending on whether an exception was a failure or an error.
 class _RemoteTestFailure extends RemoteException implements TestFailure {
-  _RemoteTestFailure(String message, String type, String toString)
+  _RemoteTestFailure(String? message, String type, String toString)
       : super._(message, type, toString);
 }

pkgs/test_api/pubspec.yaml

diff --git a/pkgs/test_api/pubspec.yaml b/pkgs/test_api/pubspec.yaml
index 33de865..188fecc 100644
--- a/pkgs/test_api/pubspec.yaml
+++ b/pkgs/test_api/pubspec.yaml
@@ -1,5 +1,5 @@
 name: test_api
-version: 0.2.20
+version: 0.3.0-dev
 description: A library for writing Dart tests.
 homepage: https://github.com/dart-lang/test/blob/master/pkgs/test_api