Remove an unnecessary await on event loop (#1164)

Closes #865

Move a `pumpEventQueue` to fix a failing test.

The test was passing because of the extra event loop cycle in
`close()`. The intent of the test is to check behavior when a test
hasn't completed yet. By closing immediately the test was actually
looking at behavior of when the tests hadn't even been declared yet, and
the extra `await` was hiding that.

Reorder the closing of the `_suiteController` and
`_onSuiteAddedController`. Values flow first through the
`_suitController` and then to the `_onSuitAddedController`. I saw at
least one case where a value flowed through late and cause an error
attempting to add a value on a closed controller.
2 files changed
tree: 180feb18bfa468033d59a0f233bbaac7aff202b4
  1. pkgs/
  2. tool/
  3. .gitignore
  4. .travis.yml
  5. analysis_options.yaml
  6. CONTRIBUTING.md
  7. mono_repo.yaml
  8. README.md
README.md

Test Mono Repository

This repository contains packages for writing and running Dart tests.

test

A full featured packaged for writing and running Dart tests on various platforms, e.g. VM, Chrome, Node etc.

test_api

A minimal package for writing tests. This package is used by package:test and package:test_core.

test_core

A minimal package for writing and running tests. It also contains extensions for implementing a custom test runner. This package is used by package:test.