tree 180feb18bfa468033d59a0f233bbaac7aff202b4
parent 26ba571a2699e69fd5f23272e91ac7fea45733a8
author Nate Bosch <nbosch1@gmail.com> 1580939602 -0800
committer GitHub <noreply@github.com> 1580939602 -0800
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJeOzlSCRBK7hj4Ov3rIwAAdHIIACeSx+366TU9nv9RztqtvQjB
 kq1UUFsqmvao+zgs1G0m/zmWTTtIuJ5q+tlqxfTRNRSsGRKFJeXxj+CpR10gZQgP
 wf3+IPqYAL7E7KkkeXZOAUxT/vL4XwpzKqLNRLAvA5kRdukfrzv9X9YgGIQJKg0K
 uuXS7tBobDcHEk0x0bw3XZVYWcViVb850eeUXmjF0PtDRYJeOoSj/bOaC9muRfGn
 Q2Le0COLtfDM0uSnJ5BXkKUtXMwgorKjooI2Tyvbu7n7Y2ZQ2FKWatEKx/k4Nn+R
 a+qXkethQajaE6GXUJNsGRLiHw1hb4MnnCIMOOK6i9Id42hY0+CJ6VxoDY5JAGw=
 =w69N
 -----END PGP SIGNATURE-----
 

Remove an unnecessary await on event loop (#1164)

Closes #865

Move a `pumpEventQueue` to fix a failing test.

The test was passing because of the extra event loop cycle in
`close()`. The intent of the test is to check behavior when a test
hasn't completed yet. By closing immediately the test was actually
looking at behavior of when the tests hadn't even been declared yet, and
the extra `await` was hiding that.

Reorder the closing of the `_suiteController` and
`_onSuiteAddedController`. Values flow first through the
`_suitController` and then to the `_onSuitAddedController`. I saw at
least one case where a value flowed through late and cause an error
attempting to add a value on a closed controller.