Refactor a sync* into a list literal (#1644)
Found while considering usage of `sync*` in general.
In this case enhanced collection literals are more readable than an
immediately invoked `sync*`.
diff --git a/pkgs/test/test/runner/tag_test.dart b/pkgs/test/test/runner/tag_test.dart
index f2f6d19..7fb2cee 100644
--- a/pkgs/test/test/runner/tag_test.dart
+++ b/pkgs/test/test/runner/tag_test.dart
@@ -352,21 +352,19 @@
/// Returns a [StreamMatcher] that asserts that a test emits warnings for [tags]
/// in order.
-StreamMatcher tagWarnings(List<String> tags) => emitsInOrder(() sync* {
- yield emitsThrough(
+StreamMatcher tagWarnings(List<String> tags) => emitsInOrder([
+ emitsThrough(
"Warning: ${tags.length == 1 ? 'A tag was' : 'Tags were'} used that "
"${tags.length == 1 ? "wasn't" : "weren't"} specified in "
- 'dart_test.yaml.');
+ 'dart_test.yaml.'),
- for (var tag in tags) {
- yield emitsThrough(startsWith(' $tag was used in'));
- }
+ for (var tag in tags) emitsThrough(startsWith(' $tag was used in')),
// Consume until the end of the warning block, and assert that it has no
// further tags than the ones we specified.
- yield mayEmitMultiple(isNot(anyOf([contains(' was used in'), isEmpty])));
- yield isEmpty;
- }());
+ mayEmitMultiple(isNot(anyOf([contains(' was used in'), isEmpty]))),
+ isEmpty,
+ ]);
/// Returns a [StreamMatcher] that matches the lines of [string] in order.
StreamMatcher lines(String string) => emitsInOrder(string.split('\n'));
