Remove --fatal-warnings (#1559)
diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml
index a83d048..d28df20 100644
--- a/.github/workflows/dart.yml
+++ b/.github/workflows/dart.yml
@@ -37,7 +37,7 @@
- name: mono_repo self validate
run: dart pub global run mono_repo generate --validate
job_002:
- name: "analyze_and_format; linux; Dart dev; PKGS: integration_tests/nnbd_opted_in, integration_tests/nnbd_opted_out, pkgs/test, pkgs/test_api, pkgs/test_core; `dart format --output=none --set-exit-if-changed .`, `dart analyze --fatal-infos --fatal-warnings .`"
+ name: "analyze_and_format; linux; Dart dev; PKGS: integration_tests/nnbd_opted_in, integration_tests/nnbd_opted_out, pkgs/test, pkgs/test_api, pkgs/test_core; `dart format --output=none --set-exit-if-changed .`, `dart analyze --fatal-infos`"
runs-on: ubuntu-latest
steps:
- name: Cache Pub hosted dependencies
@@ -64,10 +64,10 @@
if: "always() && steps.integration_tests_nnbd_opted_in_pub_upgrade.conclusion == 'success'"
working-directory: integration_tests/nnbd_opted_in
run: "dart format --output=none --set-exit-if-changed ."
- - name: "integration_tests/nnbd_opted_in; dart analyze --fatal-infos --fatal-warnings ."
+ - name: "integration_tests/nnbd_opted_in; dart analyze --fatal-infos"
if: "always() && steps.integration_tests_nnbd_opted_in_pub_upgrade.conclusion == 'success'"
working-directory: integration_tests/nnbd_opted_in
- run: dart analyze --fatal-infos --fatal-warnings .
+ run: dart analyze --fatal-infos
- id: integration_tests_nnbd_opted_out_pub_upgrade
name: integration_tests/nnbd_opted_out; dart pub upgrade
if: "always() && steps.checkout.conclusion == 'success'"
@@ -77,10 +77,10 @@
if: "always() && steps.integration_tests_nnbd_opted_out_pub_upgrade.conclusion == 'success'"
working-directory: integration_tests/nnbd_opted_out
run: "dart format --output=none --set-exit-if-changed ."
- - name: "integration_tests/nnbd_opted_out; dart analyze --fatal-infos --fatal-warnings ."
+ - name: "integration_tests/nnbd_opted_out; dart analyze --fatal-infos"
if: "always() && steps.integration_tests_nnbd_opted_out_pub_upgrade.conclusion == 'success'"
working-directory: integration_tests/nnbd_opted_out
- run: dart analyze --fatal-infos --fatal-warnings .
+ run: dart analyze --fatal-infos
- id: pkgs_test_pub_upgrade
name: pkgs/test; dart pub upgrade
if: "always() && steps.checkout.conclusion == 'success'"
@@ -90,10 +90,10 @@
if: "always() && steps.pkgs_test_pub_upgrade.conclusion == 'success'"
working-directory: pkgs/test
run: "dart format --output=none --set-exit-if-changed ."
- - name: "pkgs/test; dart analyze --fatal-infos --fatal-warnings ."
+ - name: "pkgs/test; dart analyze --fatal-infos"
if: "always() && steps.pkgs_test_pub_upgrade.conclusion == 'success'"
working-directory: pkgs/test
- run: dart analyze --fatal-infos --fatal-warnings .
+ run: dart analyze --fatal-infos
- id: pkgs_test_api_pub_upgrade
name: pkgs/test_api; dart pub upgrade
if: "always() && steps.checkout.conclusion == 'success'"
@@ -103,10 +103,10 @@
if: "always() && steps.pkgs_test_api_pub_upgrade.conclusion == 'success'"
working-directory: pkgs/test_api
run: "dart format --output=none --set-exit-if-changed ."
- - name: "pkgs/test_api; dart analyze --fatal-infos --fatal-warnings ."
+ - name: "pkgs/test_api; dart analyze --fatal-infos"
if: "always() && steps.pkgs_test_api_pub_upgrade.conclusion == 'success'"
working-directory: pkgs/test_api
- run: dart analyze --fatal-infos --fatal-warnings .
+ run: dart analyze --fatal-infos
- id: pkgs_test_core_pub_upgrade
name: pkgs/test_core; dart pub upgrade
if: "always() && steps.checkout.conclusion == 'success'"
@@ -116,10 +116,10 @@
if: "always() && steps.pkgs_test_core_pub_upgrade.conclusion == 'success'"
working-directory: pkgs/test_core
run: "dart format --output=none --set-exit-if-changed ."
- - name: "pkgs/test_core; dart analyze --fatal-infos --fatal-warnings ."
+ - name: "pkgs/test_core; dart analyze --fatal-infos"
if: "always() && steps.pkgs_test_core_pub_upgrade.conclusion == 'success'"
working-directory: pkgs/test_core
- run: dart analyze --fatal-infos --fatal-warnings .
+ run: dart analyze --fatal-infos
job_003:
name: "unit_test; linux; Dart dev; PKG: integration_tests/nnbd_opted_in; `dart test -p chrome,vm,node`"
runs-on: ubuntu-latest
diff --git a/integration_tests/nnbd_opted_in/mono_pkg.yaml b/integration_tests/nnbd_opted_in/mono_pkg.yaml
index 44560ca..b5e88d8 100644
--- a/integration_tests/nnbd_opted_in/mono_pkg.yaml
+++ b/integration_tests/nnbd_opted_in/mono_pkg.yaml
@@ -6,7 +6,7 @@
- analyze_and_format:
- group:
- format
- - analyze: --fatal-infos --fatal-warnings .
+ - analyze: --fatal-infos
dart:
- dev
- unit_test:
diff --git a/integration_tests/nnbd_opted_out/mono_pkg.yaml b/integration_tests/nnbd_opted_out/mono_pkg.yaml
index 44560ca..b5e88d8 100644
--- a/integration_tests/nnbd_opted_out/mono_pkg.yaml
+++ b/integration_tests/nnbd_opted_out/mono_pkg.yaml
@@ -6,7 +6,7 @@
- analyze_and_format:
- group:
- format
- - analyze: --fatal-infos --fatal-warnings .
+ - analyze: --fatal-infos
dart:
- dev
- unit_test:
diff --git a/pkgs/test/mono_pkg.yaml b/pkgs/test/mono_pkg.yaml
index 6b767aa..96fe0bb 100644
--- a/pkgs/test/mono_pkg.yaml
+++ b/pkgs/test/mono_pkg.yaml
@@ -6,7 +6,7 @@
- analyze_and_format:
- group:
- format
- - analyze: --fatal-infos --fatal-warnings .
+ - analyze: --fatal-infos
dart:
- dev
- unit_test:
diff --git a/pkgs/test_api/mono_pkg.yaml b/pkgs/test_api/mono_pkg.yaml
index 10382a2..3977184 100644
--- a/pkgs/test_api/mono_pkg.yaml
+++ b/pkgs/test_api/mono_pkg.yaml
@@ -6,7 +6,7 @@
- analyze_and_format:
- group:
- format
- - analyze: --fatal-infos --fatal-warnings .
+ - analyze: --fatal-infos
dart:
- dev
- unit_test:
diff --git a/pkgs/test_core/mono_pkg.yaml b/pkgs/test_core/mono_pkg.yaml
index 626345d..2c7e3f6 100644
--- a/pkgs/test_core/mono_pkg.yaml
+++ b/pkgs/test_core/mono_pkg.yaml
@@ -5,4 +5,4 @@
- analyze_and_format:
- group:
- format
- - analyze: --fatal-infos --fatal-warnings .
+ - analyze: --fatal-infos
diff --git a/tool/ci.sh b/tool/ci.sh
index a2ccc8c..1595dc2 100755
--- a/tool/ci.sh
+++ b/tool/ci.sh
@@ -68,8 +68,8 @@
echo -e "\033[1mPKG: ${PKG}; TASK: ${TASK}\033[22m"
case ${TASK} in
analyze)
- echo 'dart analyze --fatal-infos --fatal-warnings .'
- dart analyze --fatal-infos --fatal-warnings . || EXIT_CODE=$?
+ echo 'dart analyze --fatal-infos'
+ dart analyze --fatal-infos || EXIT_CODE=$?
;;
command_0)
echo 'xvfb-run -s "-screen 0 1024x768x24" dart test --preset travis --total-shards 5 --shard-index 0'