commit c4dd35605e3ab6df5da77b47a318f4ad8a17483d
author Danny Tuppeny <danny@tuppeny.com> Thu Aug 20 10:21:27 2020 +0100
committer Danny Tuppeny <danny@tuppeny.com> Thu Aug 20 10:21:27 2020 +0100
tree ee5338adad26a2244347587c59bb838be3d9b380
parent ae8a757f17bf20dd745784605a4f695bb73eb162

Use file modified date for 304 checks ("changed" is creation date on Windows)

Fixes #37.

lib/src/static_handler.dart

diff --git a/lib/src/static_handler.dart b/lib/src/static_handler.dart
index b6131ea..4f278ec 100644
--- a/lib/src/static_handler.dart
+++ b/lib/src/static_handler.dart
@@ -182,7 +182,7 @@
   var ifModifiedSince = request.ifModifiedSince;
 
   if (ifModifiedSince != null) {
-    var fileChangeAtSecResolution = toSecondResolution(stat.changed);
+    var fileChangeAtSecResolution = toSecondResolution(stat.modified);
     if (!fileChangeAtSecResolution.isAfter(ifModifiedSince)) {
       return new Response.notModified();
     }
@@ -190,7 +190,7 @@
 
   var headers = {
     HttpHeaders.contentLengthHeader: stat.size.toString(),
-    HttpHeaders.lastModifiedHeader: formatHttpDate(stat.changed)
+    HttpHeaders.lastModifiedHeader: formatHttpDate(stat.modified)
   };
 
   var contentType = await getContentType();

test/basic_file_test.dart

diff --git a/test/basic_file_test.dart b/test/basic_file_test.dart
index 2b31dd6..bea7e16 100644
--- a/test/basic_file_test.dart
+++ b/test/basic_file_test.dart
@@ -86,7 +86,7 @@
     var handler = createStaticHandler(d.sandbox);
 
     var rootPath = p.join(d.sandbox, 'root.txt');
-    var modified = new File(rootPath).statSync().changed.toUtc();
+    var modified = new File(rootPath).statSync().modified.toUtc();
 
     var response = await makeRequest(handler, '/root.txt');
     expect(response.lastModified, atSameTimeToSecond(modified));
@@ -97,7 +97,7 @@
       var handler = createStaticHandler(d.sandbox);
 
       var rootPath = p.join(d.sandbox, 'root.txt');
-      var modified = new File(rootPath).statSync().changed.toUtc();
+      var modified = new File(rootPath).statSync().modified.toUtc();
 
       var headers = {
         HttpHeaders.ifModifiedSinceHeader: formatHttpDate(modified)
@@ -112,7 +112,7 @@
       var handler = createStaticHandler(d.sandbox);
 
       var rootPath = p.join(d.sandbox, 'root.txt');
-      var modified = new File(rootPath).statSync().changed.toUtc();
+      var modified = new File(rootPath).statSync().modified.toUtc();
 
       var headers = {
         HttpHeaders.ifModifiedSinceHeader:
@@ -128,7 +128,7 @@
       var handler = createStaticHandler(d.sandbox);
 
       var rootPath = p.join(d.sandbox, 'root.txt');
-      var modified = new File(rootPath).statSync().changed.toUtc();
+      var modified = new File(rootPath).statSync().modified.toUtc();
 
       var headers = {
         HttpHeaders.ifModifiedSinceHeader:

test/sample_test.dart

diff --git a/test/sample_test.dart b/test/sample_test.dart
index 1c4b85f..87d2486 100644
--- a/test/sample_test.dart
+++ b/test/sample_test.dart
@@ -62,7 +62,7 @@
 
   var response = await _requestFile(filename);
   expect(response.contentLength, fileStat.size);
-  expect(response.lastModified, atSameTimeToSecond(fileStat.changed.toUtc()));
+  expect(response.lastModified, atSameTimeToSecond(fileStat.modified.toUtc()));
   await _expectCompletesWithBytes(response, fileContents);
 }