commit c511f06e6d2d28ffe905a45eea1da761b95ea0ca
author Kevin Moore <kevmoo@users.noreply.github.com> Fri May 07 13:42:06 2021 -0700
committer GitHub <noreply@github.com> Fri May 07 13:42:06 2021 -0700
tree 50102258265d667e8727a081344c3cf1ec51935f
parent bd342055fa45b76b99613630b13810a6b60f2f3f

Allow an explicit non-zero content-length header if the body is empty. (#181)

Needed to correctly support HEAD requests

Also prepare to release v1.1.2

CHANGELOG.md

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 28d255f..c428250 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,7 @@
-## 1.1.2-dev
+## 1.1.2
+
+* Allow an explicit non-zero content-length header if the body is empty.
+  (Needed to correctly support HEAD requests).
 
 ## 1.1.1
 

lib/src/message.dart

diff --git a/lib/src/message.dart b/lib/src/message.dart
index 8e98915..91704b2 100644
--- a/lib/src/message.dart
+++ b/lib/src/message.dart
@@ -206,7 +206,10 @@
     }
   }
 
-  if (body.contentLength != null) {
+  final explicitOverrideOfZeroLength =
+      body.contentLength == 0 && findHeader(headers, 'content-length') != null;
+
+  if (body.contentLength != null && !explicitOverrideOfZeroLength) {
     final coding = joinHeaderValues(newHeaders['transfer-encoding']);
     if (coding == null || equalsIgnoreAsciiCase(coding, 'identity')) {
       newHeaders['content-length'] = [body.contentLength.toString()];

pubspec.yaml

diff --git a/pubspec.yaml b/pubspec.yaml
index ae9a892..9af2e0a 100644
--- a/pubspec.yaml
+++ b/pubspec.yaml
@@ -1,5 +1,5 @@
 name: shelf
-version: 1.1.2-dev
+version: 1.1.2
 description: >-
   A model for web server middleware that encourages composition and easy reuse
 repository: https://github.com/dart-lang/shelf

test/response_test.dart

diff --git a/test/response_test.dart b/test/response_test.dart
index e46f783..19058e2 100644
--- a/test/response_test.dart
+++ b/test/response_test.dart
@@ -58,6 +58,14 @@
         isA<List<int>>().having((values) => values, 'values', [1, 2, 3, 4]));
   });
 
+  test('allows content-length header even if body is null', () async {
+    // needed for HEAD responses
+    var response = Response.ok(null, headers: {'Content-Length': '42'});
+
+    expect(response.contentLength, 42);
+    expect(await response.readAsString(), isEmpty);
+  });
+
   group('new Response.internalServerError without a body', () {
     test('sets the body to "Internal Server Error"', () {
       var response = Response.internalServerError();