commit 375dd47a47c4b71c06d6b10794f2a40774e6b12b
author Sam Rawlins <srawlins@google.com> Thu May 23 11:35:08 2019 -0700
committer GitHub <noreply@github.com> Thu May 23 11:35:08 2019 -0700
tree 92aa3fc5861650695edaafd8cf2bed0189250dd6
parent 714f97bd46297c32ed155c08282ca8b8ff0da5fa
parent 6ef84ba9ab60c26ae03c10f15a1e2654ca2b5e5f

Merge pull request #117 from srawlins/missing-return

Fix missing_return violation newly enforced in Dart ~2.3.2-dev.0.1

test/io_server_test.dart

diff --git a/test/io_server_test.dart b/test/io_server_test.dart
index 54bb0b9..0ed2a59 100644
--- a/test/io_server_test.dart
+++ b/test/io_server_test.dart
@@ -39,8 +39,8 @@
   });
 
   test("disallows more than one handler from being mounted", () async {
-    server.mount((_) {});
-    expect(() => server.mount((_) {}), throwsStateError);
-    expect(() => server.mount((_) {}), throwsStateError);
+    server.mount((_) => null);
+    expect(() => server.mount((_) => null), throwsStateError);
+    expect(() => server.mount((_) => null), throwsStateError);
   });
 }

test/server_handler_test.dart

diff --git a/test/server_handler_test.dart b/test/server_handler_test.dart
index 9b44349..8a23b51 100644
--- a/test/server_handler_test.dart
+++ b/test/server_handler_test.dart
@@ -40,7 +40,7 @@
 
   test("stops servicing requests after Server.close is called", () {
     var serverHandler = ServerHandler(localhostUri);
-    serverHandler.server.mount(expectAsync1((_) {}, count: 0));
+    serverHandler.server.mount(expectAsync1((_) => null, count: 0));
     serverHandler.server.close();
 
     expect(makeSimpleRequest(serverHandler.handler), throwsStateError);
@@ -70,8 +70,8 @@
 
   test("doesn't allow Server.mount to be called multiple times", () {
     var serverHandler = ServerHandler(localhostUri);
-    serverHandler.server.mount((_) {});
-    expect(() => serverHandler.server.mount((_) {}), throwsStateError);
-    expect(() => serverHandler.server.mount((_) {}), throwsStateError);
+    serverHandler.server.mount((_) => null);
+    expect(() => serverHandler.server.mount((_) => null), throwsStateError);
+    expect(() => serverHandler.server.mount((_) => null), throwsStateError);
   });
 }

test/shelf_io_test.dart

diff --git a/test/shelf_io_test.dart b/test/shelf_io_test.dart
index c679cd0..1012894 100644
--- a/test/shelf_io_test.dart
+++ b/test/shelf_io_test.dart
@@ -216,6 +216,7 @@
             .codeUnits);
         channel.sink.close();
       }));
+      return null;
     });
 
     var response = await _post(body: "Hello");