Fix most of the hints - thanks to `dart fix` (#81)
* Fix most of the hints - thanks to `dart fix`
* oops
diff --git a/pkgs/shelf_router/lib/src/router.dart b/pkgs/shelf_router/lib/src/router.dart
index 6e58f5e..a6b8711 100644
--- a/pkgs/shelf_router/lib/src/router.dart
+++ b/pkgs/shelf_router/lib/src/router.dart
@@ -23,11 +23,11 @@
final p = request.context['shelf_router/params'];
if (!(p is Map<String, String>)) {
- throw new Exception('no such parameter $name');
+ throw Exception('no such parameter $name');
}
final value = (p as Map<String, String>)[name];
if (value == null) {
- throw new Exception('no such parameter $name');
+ throw Exception('no such parameter $name');
}
return value;
}
diff --git a/pkgs/shelf_router/lib/src/router_entry.dart b/pkgs/shelf_router/lib/src/router_entry.dart
index 251a91a..5130f50 100644
--- a/pkgs/shelf_router/lib/src/router_entry.dart
+++ b/pkgs/shelf_router/lib/src/router_entry.dart
@@ -41,7 +41,7 @@
RegExp _routePattern;
/// Names for the parameters in the route pattern.
- List<String> _params = [];
+ final List<String> _params = [];
/// List of parameter names in the route pattern.
List<String> get params => _params.toList(); // exposed for using generator.
@@ -88,7 +88,7 @@
}
// Construct map from parameter name to matched value
var params = <String, String>{};
- for (int i = 0; i < _params.length; i++) {
+ for (var i = 0; i < _params.length; i++) {
// first group is always the full match, we ignore this group.
params[_params[i]] = m[i + 1];
}
diff --git a/pkgs/shelf_router_generator/lib/src/shelf_router_generator.dart b/pkgs/shelf_router_generator/lib/src/shelf_router_generator.dart
index 36e676d..b2a28c0 100644
--- a/pkgs/shelf_router_generator/lib/src/shelf_router_generator.dart
+++ b/pkgs/shelf_router_generator/lib/src/shelf_router_generator.dart
@@ -13,6 +13,7 @@
// limitations under the License.
import 'dart:async' show Future;
+
import 'package:analyzer/dart/element/element.dart'
show ClassElement, ElementKind, ExecutableElement;
import 'package:analyzer/dart/element/type.dart' show ParameterizedType;
@@ -20,10 +21,10 @@
import 'package:code_builder/code_builder.dart' as code;
import 'package:http_methods/http_methods.dart' show isHttpMethod;
import 'package:meta/meta.dart';
-import 'package:source_gen/source_gen.dart' as g;
import 'package:shelf/shelf.dart' as shelf;
import 'package:shelf_router/shelf_router.dart' as shelf_router;
import 'package:shelf_router/src/router_entry.dart' show RouterEntry;
+import 'package:source_gen/source_gen.dart' as g;
// Type checkers that we need later
final _routeType = g.TypeChecker.fromRuntime(shelf_router.Route);
@@ -225,7 +226,7 @@
'shelf.Request parameter and all string parameters in the route',
element: h.element);
}
- for (int i = 0; i < params.length; i++) {
+ for (var i = 0; i < params.length; i++) {
final p = h.element.parameters[i + 1];
if (p.name != params[i]) {
throw g.InvalidGenerationSourceError(
diff --git a/pkgs/shelf_router_generator/test/server_test.dart b/pkgs/shelf_router_generator/test/server_test.dart
index 85b0852..cb0002c 100644
--- a/pkgs/shelf_router_generator/test/server_test.dart
+++ b/pkgs/shelf_router_generator/test/server_test.dart
@@ -22,7 +22,7 @@
setUpAll(() => server.start());
tearDownAll(() => server.stop());
- testGet({
+ void testGet({
@required String path,
@required String result,
}) =>
