[vm] Fix byte displacement printing in x86 disassembler Use int8_t type instead of char - which does not have a defined signedness. Change-Id: I14d43419d3e59cea71fb27f15bb1f72e450baca6 Reviewed-on: https://dart-review.googlesource.com/76563 Reviewed-by: Ryan Macnak <rmacnak@google.com> Reviewed-by: Aart Bik <ajcbik@google.com> Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
diff --git a/runtime/vm/compiler/assembler/disassembler_x86.cc b/runtime/vm/compiler/assembler/disassembler_x86.cc index 6e7089e..b6c2324 100644 --- a/runtime/vm/compiler/assembler/disassembler_x86.cc +++ b/runtime/vm/compiler/assembler/disassembler_x86.cc
@@ -443,7 +443,7 @@ int scale, index, base; get_sib(sib, &scale, &index, &base); int disp = (mod == 2) ? *reinterpret_cast<int32_t*>(modrmp + 2) - : *reinterpret_cast<char*>(modrmp + 2); + : *reinterpret_cast<int8_t*>(modrmp + 2); if (index == 4 && (base & 7) == 4 && scale == 0 /*times_1*/) { Print("[%s", NameOfCPURegister(base)); PrintDisp(disp, "]"); @@ -456,7 +456,7 @@ } else { // No sib. int disp = (mod == 2) ? *reinterpret_cast<int32_t*>(modrmp + 1) - : *reinterpret_cast<char*>(modrmp + 1); + : *reinterpret_cast<int8_t*>(modrmp + 1); Print("[%s", NameOfCPURegister(rm)); PrintDisp(disp, "]"); return (mod == 2) ? 5 : 2;