Pass SharedOptions to Fasta Change-Id: Idf85bf49e0ddd47640719eb65044f0b6527f9d9c Reviewed-on: https://dart-review.googlesource.com/c/78525 Commit-Queue: Peter von der Ahé <ahe@google.com> Reviewed-by: William Hesse <whesse@google.com>
diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart index 1ca96e7..5cce89d 100644 --- a/tools/testing/dart/compiler_configuration.dart +++ b/tools/testing/dart/compiler_configuration.dart
@@ -1163,7 +1163,7 @@ List<String> dart2jsOptions, List<String> ddcOptions, List<String> args) { - List<String> arguments = <String>[]; + List<String> arguments = new List<String>.from(sharedOptions); for (String argument in args) { if (argument == "--ignore-unrecognized-flags") continue; arguments.add(argument);
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart index 3cd18ab..0428eff 100644 --- a/tools/testing/dart/test_suite.dart +++ b/tools/testing/dart/test_suite.dart
@@ -1184,6 +1184,10 @@ assert(!isMultitest || dartOptions == null); args.add(filePath.toNativePath()); if (dartOptions != null) { + // TODO(ahe): Because we add [dartOptions] here, + // [CompilerConfiguration.computeCompilerArguments] has to discard them + // later. Perhaps it would be simpler to pass [dartOptions] to + // [CompilerConfiguration.computeRuntimeArguments]. args.addAll(dartOptions); }