commit ff2e8eb681fdf93a30f264e5b7a8623e16e73762
author Ryan Macnak <rmacnak@google.com> Mon Jan 28 22:28:37 2019 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Mon Jan 28 22:28:37 2019 +0000
tree fd28b63753ffeea310e0b194879edb937d5a144d
parent 1ba59eb13df61e452cdc39a0dc8100645ced6b93

[vm, gc] Fix backwards write-barrier logic used by Object::Clone.

Change-Id: Ib614c0e85a96604252a47ad81ad6a8e70509a671
Reviewed-on: https://dart-review.googlesource.com/c/91242
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>

runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index 607d5b4..e0072d7 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -2082,14 +2082,14 @@
       for (RawObject** slot = from; slot <= to; ++slot) {
         RawObject* value = *slot;
         if (value->IsHeapObject()) {
-          old_obj_->CheckHeapPointerStore(value, thread_);
+          old_obj_->CheckArrayPointerStore(slot, value, thread_);
         }
       }
     } else {
       for (RawObject** slot = from; slot <= to; ++slot) {
         RawObject* value = *slot;
         if (value->IsHeapObject()) {
-          old_obj_->CheckArrayPointerStore(slot, value, thread_);
+          old_obj_->CheckHeapPointerStore(value, thread_);
         }
       }
     }