| commit | fd3eaa68318850697eb610483b8f8f866c28cdc6 | [log] [tgz] |
|---|---|---|
| author | Sam Rawlins <srawlins@google.com> | Mon Mar 17 10:21:44 2025 -0700 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 17 10:21:44 2025 -0700 |
| tree | 30c17d3277d744a4d5f1391607fe72843d09393e | |
| parent | a9ea5044cd6a7100547d6057487b5ca1d74bccfe [diff] |
_http: ensure _HttpProfileData.startResponse is called before finishResponse Fixes https://github.com/flutter/devtools/issues/8509 From my research into the bug: > I see indeed that `_HttpProfileData.finishResponse()` is called before `_HttpProfileData.startResponse()`. I think this is just a result of microtask scheduling; when the response has no body, `_incoming.dataDone` completes before `_httpRequest._responseCompleter`. > Since `startResponse` is responsible for setting `responseInProgress` to `true`, the call to `finishResponse` short circuit returns immediately. We therefore don't finish the response timeline, or log the end time, etc. The fix here does not rely on microtask organization, which I think would be fragile. Instead, we don't listen to the `dataDone` future until we've logged the start of the response. Change-Id: Ib735742b297a261e6566ae8caf9eac0d71fc8fdb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/415140 Reviewed-by: Ben Konyi <bkonyi@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.