tree 30c17d3277d744a4d5f1391607fe72843d09393e
parent a9ea5044cd6a7100547d6057487b5ca1d74bccfe
author Sam Rawlins <srawlins@google.com> 1742232104 -0700
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> 1742232104 -0700

_http: ensure _HttpProfileData.startResponse is called before finishResponse

Fixes https://github.com/flutter/devtools/issues/8509

From my research into the bug:

> I see indeed that `_HttpProfileData.finishResponse()` is called before `_HttpProfileData.startResponse()`. I think this is just a result of microtask scheduling; when the response has no body, `_incoming.dataDone` completes before `_httpRequest._responseCompleter`.

> Since `startResponse` is responsible for setting `responseInProgress` to `true`, the call to `finishResponse` short circuit returns immediately. We therefore don't finish the response timeline, or log the end time, etc.

The fix here does not rely on microtask organization, which I think would be fragile. Instead, we don't listen to the `dataDone` future
until we've logged the start of the response.

Change-Id: Ib735742b297a261e6566ae8caf9eac0d71fc8fdb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/415140
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>