blob: dd0e60d5aaaeb99c1884cc68cdc5044eb5de3166 [file] [log] [blame]
// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
import 'package:analyzer/dart/analysis/features.dart';
import 'package:analyzer/src/error/codes.dart';
import 'package:analyzer/src/generated/engine.dart';
import 'package:analyzer/src/test_utilities/package_mixin.dart';
import 'package:test_reflective_loader/test_reflective_loader.dart';
import '../dart/resolution/driver_resolution.dart';
main() {
defineReflectiveSuite(() {
defineReflectiveTests(MissingRequiredParamTest);
defineReflectiveTests(MissingRequiredParamWithNnbdTest);
});
}
@reflectiveTest
class MissingRequiredParamTest extends DriverResolutionTest with PackageMixin {
test_constructorParam_argumentGiven() async {
addMetaPackage();
await assertNoErrorsInCode(r'''
import 'package:meta/meta.dart';
class C {
C({@required int a}) {}
}
main() {
new C(a: 2);
}
''');
}
test_constructorParam_missingArgument() async {
addMetaPackage();
await assertErrorsInCode(r'''
import 'package:meta/meta.dart';
class C {
C({@Required('must specify an `a`') int a}) {}
}
main() {
new C();
}
''', [
error(HintCode.MISSING_REQUIRED_PARAM_WITH_DETAILS, 109, 1),
]);
}
test_constructorParam_noReason() async {
addMetaPackage();
await assertErrorsInCode(r'''
import 'package:meta/meta.dart';
class C {
C({@required int a}) {}
}
main() {
new C();
}
''', [
error(HintCode.MISSING_REQUIRED_PARAM, 88, 1),
]);
}
test_constructorParam_nullReason() async {
addMetaPackage();
await assertErrorsInCode(r'''
import 'package:meta/meta.dart';
class C {
C({@Required(null) int a}) {}
}
main() {
new C();
}
''', [
error(HintCode.MISSING_REQUIRED_PARAM, 94, 1),
]);
}
test_constructorParam_redirectingConstructorCall() async {
addMetaPackage();
await assertErrorsInCode(r'''
import 'package:meta/meta.dart';
class C {
C({@required int x});
C.named() : this();
}
''', [
error(HintCode.MISSING_REQUIRED_PARAM, 81, 6),
]);
}
test_constructorParam_superCall() async {
addMetaPackage();
await assertErrorsInCode(r'''
import 'package:meta/meta.dart';
class C {
C({@Required('must specify an `a`') int a}) {}
}
class D extends C {
D() : super();
}
''', [
error(HintCode.MISSING_REQUIRED_PARAM_WITH_DETAILS, 124, 7),
]);
}
test_functionParam() async {
addMetaPackage();
await assertErrorsInCode(r'''
import 'package:meta/meta.dart';
void f({@Required('must specify an `a`') int a}) {}
main() {
f();
}
''', [
error(HintCode.MISSING_REQUIRED_PARAM_WITH_DETAILS, 98, 1),
]);
}
test_methodParam() async {
addMetaPackage();
await assertErrorsInCode(r'''
import 'package:meta/meta.dart';
class A {
void m({@Required('must specify an `a`') int a}) {}
}
f() {
new A().m();
}
''', [
error(HintCode.MISSING_REQUIRED_PARAM_WITH_DETAILS, 115, 1),
]);
}
test_methodParam_inOtherLib() async {
addMetaPackage();
newFile('/a_lib.dart', content: r'''
library a_lib;
import 'package:meta/meta.dart';
class A {
void m({@Required('must specify an `a`') int a}) {}
}
''');
newFile('/test.dart', content: r'''
import "a_lib.dart";
f() {
new A().m();
}
''');
await _resolveTestFile('/a_lib.dart');
await _resolveTestFile('/test.dart');
assertTestErrorsWithCodes([HintCode.MISSING_REQUIRED_PARAM_WITH_DETAILS]);
}
test_typedef_functionParam() async {
addMetaPackage();
await assertErrorsInCode(r'''
import 'package:meta/meta.dart';
String test(C c) => c.m()();
typedef String F({@required String x});
class C {
F m() => ({@required String x}) => null;
}
''', [
error(HintCode.MISSING_REQUIRED_PARAM, 54, 7),
]);
}
/// Resolve the test file at [path].
///
/// Similar to ResolutionTest.resolveTestFile, but a custom path is supported.
Future<void> _resolveTestFile(String path) async {
result = await resolveFile(convertPath(path));
}
}
@reflectiveTest
class MissingRequiredParamWithNnbdTest extends DriverResolutionTest {
@override
AnalysisOptionsImpl get analysisOptions => AnalysisOptionsImpl()
..contextFeatures = new FeatureSet.forTesting(
sdkVersion: '2.3.0', additionalFeatures: [Feature.non_nullable]);
test_constructorParam_argumentGiven() async {
await assertNoErrorsInCode(r'''
class C {
C({required int a}) {}
}
main() {
new C(a: 2);
}
''');
}
test_constructorParam_missingArgument() async {
await assertErrorsInCode(r'''
class C {
C({required int a}) {}
}
main() {
new C();
}
''', [
error(CompileTimeErrorCode.MISSING_REQUIRED_ARGUMENT, 52, 1),
]);
}
test_constructorParam_redirectingConstructorCall() async {
await assertErrorsInCode(r'''
class C {
C({required int x});
C.named() : this();
}
''', [
error(CompileTimeErrorCode.MISSING_REQUIRED_ARGUMENT, 47, 6),
]);
}
test_constructorParam_superCall() async {
await assertErrorsInCode(r'''
class C {
C({required int a}) {}
}
class D extends C {
D() : super();
}
''', [
error(CompileTimeErrorCode.MISSING_REQUIRED_ARGUMENT, 66, 7),
]);
}
test_functionInvocation() async {
await assertErrorsInCode(r'''
void Function({required int a}) f() => null;
g() {
f()();
}
''', [
error(CompileTimeErrorCode.MISSING_REQUIRED_ARGUMENT, 53, 5),
]);
}
test_functionParam() async {
await assertErrorsInCode(r'''
void f({required int a}) {}
main() {
f();
}
''', [
error(CompileTimeErrorCode.MISSING_REQUIRED_ARGUMENT, 40, 1),
]);
}
test_methodParam() async {
await assertErrorsInCode(r'''
class A {
void m({required int a}) {}
}
f() {
new A().m();
}
''', [
error(CompileTimeErrorCode.MISSING_REQUIRED_ARGUMENT, 58, 1),
]);
}
test_methodParam_inOtherLib() async {
newFile('/test/lib/a_lib.dart', content: r'''
class A {
void m({required int a}) {}
}
''');
await assertErrorsInCode(r'''
import "a_lib.dart";
f() {
new A().m();
}
''', [
error(CompileTimeErrorCode.MISSING_REQUIRED_ARGUMENT, 37, 1),
]);
}
test_typedef_functionParam() async {
await assertErrorsInCode(r'''
String test(C c) => c.m()();
typedef String F({required String x});
class C {
F m() => ({required String x}) => null;
}
''', [
error(CompileTimeErrorCode.MISSING_REQUIRED_ARGUMENT, 20, 7),
]);
}
}