commit f8cca09ce3df79ddaad232879ed96f944ab0de72
author Martin Kustermann <kustermann@google.com> Wed May 23 12:52:08 2018 +0000
committer Martin Kustermann <kustermann@google.com> Wed May 23 12:52:08 2018 +0000
tree da8c540865030c0f98a9375427e62ae009c8e07b
parent 39bccc125d0c02a5ce7f3610869050cbf81fea11

[VM] Do not invoke the empty StackOverflowError/OutOfMemoryError constructors

Issue https://github.com/dart-lang/sdk/issues/33185

Change-Id: If5bf7269cede7ed4a643bc338c964dacdc03cdaf
Reviewed-on: https://dart-review.googlesource.com/56324
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>

runtime/vm/object_store.cc

diff --git a/runtime/vm/object_store.cc b/runtime/vm/object_store.cc
index 43b9a5c..2d62110 100644
--- a/runtime/vm/object_store.cc
+++ b/runtime/vm/object_store.cc
@@ -57,6 +57,13 @@
 }
 #endif  // !PRODUCT
 
+static RawInstance* AllocateObjectByClassName(const Library& library,
+                                              const String& class_name) {
+  const Class& cls = Class::Handle(library.LookupClassAllowPrivate(class_name));
+  ASSERT(!cls.IsNull());
+  return Instance::New(cls);
+}
+
 RawError* ObjectStore::PreallocateObjects() {
   Thread* thread = Thread::Current();
   Isolate* isolate = thread->isolate();
@@ -81,17 +88,13 @@
   Object& result = Object::Handle();
   const Library& library = Library::Handle(Library::CoreLibrary());
 
-  result =
-      DartLibraryCalls::InstanceCreate(library, Symbols::StackOverflowError(),
-                                       Symbols::Dot(), Object::empty_array());
+  result = AllocateObjectByClassName(library, Symbols::StackOverflowError());
   if (result.IsError()) {
     return Error::Cast(result).raw();
   }
   set_stack_overflow(Instance::Cast(result));
 
-  result =
-      DartLibraryCalls::InstanceCreate(library, Symbols::OutOfMemoryError(),
-                                       Symbols::Dot(), Object::empty_array());
+  result = AllocateObjectByClassName(library, Symbols::OutOfMemoryError());
   if (result.IsError()) {
     return Error::Cast(result).raw();
   }