[infra] Upgrade gsutil to version 4.34
Change-Id: Id353fa11a8f86415569a505ef5ecd7bf03fb51e1
Reviewed-on: https://dart-review.googlesource.com/c/90487
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
diff --git a/DEPS b/DEPS
index 2df2e7c..ad8ed00 100644
--- a/DEPS
+++ b/DEPS
@@ -190,6 +190,14 @@
"https://boringssl.googlesource.com/boringssl.git" +
"@" + Var("boringssl_rev"),
+ Var("dart_root") + "/third_party/gsutil": {
+ "packages": [{
+ "package": "infra/gsutil",
+ "version": "version:4.34",
+ }],
+ "dep_type": "cipd",
+ },
+
Var("dart_root") + "/third_party/root_certificates":
Var("dart_git") + "root_certificates.git" +
"@" + Var("root_certificates_rev"),
@@ -451,20 +459,6 @@
],
},
{
- "name": "gsutil",
- "pattern": ".",
- "action": [
- "download_from_google_storage",
- "--no_auth",
- "--no_resume",
- "--bucket",
- "dart-dependencies",
- "--extract",
- "-s",
- Var('dart_root') + "/third_party/gsutil.tar.gz.sha1",
- ],
- },
- {
# Pull Debian wheezy sysroot for i386 Linux
'name': 'sysroot_i386',
'pattern': '.',
diff --git a/third_party/.gitignore b/third_party/.gitignore
index b0b3349..836a11d 100644
--- a/third_party/.gitignore
+++ b/third_party/.gitignore
@@ -9,7 +9,6 @@
!d8
!7zip.tar.gz.sha1
!firefox_jsshell
-!gsutil.tar.gz.sha1
!clang.tar.gz.sha1
!unittest.tar.gz.sha1
!update.sh
diff --git a/third_party/gsutil.tar.gz.sha1 b/third_party/gsutil.tar.gz.sha1
deleted file mode 100644
index cfc510a..0000000
--- a/third_party/gsutil.tar.gz.sha1
+++ /dev/null
@@ -1 +0,0 @@
-99b82a42b98b78fc2a3f155995a16d8d7517b657
\ No newline at end of file
diff --git a/tools/bots/dart_sdk.py b/tools/bots/dart_sdk.py
index 50f3978..be81900 100755
--- a/tools/bots/dart_sdk.py
+++ b/tools/bots/dart_sdk.py
@@ -44,14 +44,14 @@
'dart-sdk')
dart_exe = os.path.join(dart_sdk, 'bin', 'dart')
dartdoc_dart = os.path.join(bot_utils.DART_DIR,
- 'third_party', 'pkg' , 'dartdoc' , 'bin' ,
+ 'third_party', 'pkg', 'dartdoc', 'bin',
'dartdoc.dart')
footer_file = os.path.join(bot_utils.DART_DIR,
'tools', 'bots', 'dartdoc_footer.html')
url = 'https://api.dartlang.org/stable'
with bot.BuildStep('Build API docs by dartdoc'):
bot_utils.run([dart_exe, dartdoc_dart,
- '--sdk-docs','--output', dirname, '--footer' , footer_file,
+ '--sdk-docs', '--output', dirname, '--footer', footer_file,
'--rel-canonical-prefix=' + url])
def CreateUploadVersionFile():
@@ -172,7 +172,7 @@
throw_on_error=False)
# If the returncode is nonzero and we can find a specific error message,
# we know there are no objects with a prefix of [gsu_path].
- missing = (returncode and 'CommandException: No such object' in stderr)
+ missing = (returncode and 'CommandException: One or more URLs matched no objects.' in stderr)
# Either the returncode has to be zero or the object must be missing,
# otherwise throw an exception.
if not missing and returncode:
diff --git a/tools/bots/test_matrix.json b/tools/bots/test_matrix.json
index a617489..ba372a4 100644
--- a/tools/bots/test_matrix.json
+++ b/tools/bots/test_matrix.json
@@ -136,7 +136,6 @@
"samples-dev/",
"tools/",
"third_party/android_tools/sdk/platform-tools/adb",
- "third_party/gsutil/",
"third_party/pkg/",
"third_party/pkg_tested/",
"third_party/observatory_pub_packages/packages/",