Remove parser "synthetic_identifier_<#>"
This should fix https://github.com/dart-lang/sdk/issues/33157
Change-Id: I372d8b3f57388dea4e58673e4212fa69cfff2e72
Reviewed-on: https://dart-review.googlesource.com/63180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
diff --git a/pkg/front_end/lib/src/fasta/parser/parser.dart b/pkg/front_end/lib/src/fasta/parser/parser.dart
index 2363720..5aa6c35 100644
--- a/pkg/front_end/lib/src/fasta/parser/parser.dart
+++ b/pkg/front_end/lib/src/fasta/parser/parser.dart
@@ -1874,15 +1874,8 @@
Token next = token.next;
reportRecoverableError(messageOnToken ?? next,
message ?? context.recoveryTemplate.withArguments(next));
- Token identifier = new SyntheticStringToken(
- TokenType.IDENTIFIER,
- context == IdentifierContext.methodDeclaration ||
- context == IdentifierContext.topLevelVariableDeclaration ||
- context == IdentifierContext.fieldDeclaration
- ? '#synthetic_identifier_${next.offset}'
- : '',
- next.charOffset,
- 0);
+ Token identifier =
+ new SyntheticStringToken(TokenType.IDENTIFIER, '', next.charOffset, 0);
rewriter.insertTokenAfter(token, identifier);
return token.next;
}
diff --git a/tests/co19/co19-dart2js.status b/tests/co19/co19-dart2js.status
index 96e1f72..d3adcfd 100644
--- a/tests/co19/co19-dart2js.status
+++ b/tests/co19/co19-dart2js.status
@@ -7070,22 +7070,11 @@
WebPlatformTest/html/semantics/embedded-content/the-audio-element/audio_constructor_t01: RuntimeError
[ $compiler == dart2js && $fasta && $host_checked ]
-Language/Classes/Constructors/Factories/redirecting_constructor_t03: Crash
Language/Classes/Constructors/Generative_Constructors/execution_t04: Crash
Language/Classes/Constructors/Generative_Constructors/execution_t05: Crash
Language/Classes/Constructors/Generative_Constructors/execution_t06: Crash
Language/Classes/Constructors/Generative_Constructors/execution_t07: Crash
Language/Classes/Constructors/Generative_Constructors/execution_t12: Crash
-Language/Classes/Constructors/Generative_Constructors/initializers_t12: Crash # Issue 33157
-Language/Classes/Instance_Methods/Operators/allowed_names_t20: Crash
-Language/Classes/member_definition_t04: Crash
-Language/Classes/member_definition_t06: Crash
-Language/Classes/member_definition_t07: Crash
-Language/Classes/member_definition_t08: Crash
-Language/Classes/member_definition_t09: Crash
-Language/Classes/member_definition_t10: Crash
-Language/Classes/member_definition_t11: Crash
-Language/Classes/member_definition_t12: Crash
Language/Expressions/Constants/depending_on_itself_t03: Crash
Language/Expressions/Function_Invocation/Unqualified_Invocation/instance_context_invocation_t04: Crash
Language/Expressions/Method_Invocation/Super_Invocation/accessible_instance_member_t02: Crash
diff --git a/tests/language/language_dart2js.status b/tests/language/language_dart2js.status
index 8b2f12e..f21f652 100644
--- a/tests/language/language_dart2js.status
+++ b/tests/language/language_dart2js.status
@@ -569,8 +569,6 @@
number_identity_test: CompileTimeError
sync_generator2_test/41: Crash # 'file:*/pkg/compiler/lib/src/kernel/element_map_impl.dart': Failed assertion: line 939 pos 18: 'asyncMarker == AsyncMarker.SYNC': is not true.
sync_generator2_test/52: Crash # 'file:*/pkg/compiler/lib/src/kernel/element_map_impl.dart': Failed assertion: line 939 pos 18: 'asyncMarker == AsyncMarker.SYNC': is not true.
-syntax_test/21: Crash # 'file:*/pkg/compiler/lib/src/kernel/env.dart': Failed assertion: line 322 pos 16: '!name.contains('#')': is not true.
-syntax_test/22: Crash # 'file:*/pkg/compiler/lib/src/kernel/env.dart': Failed assertion: line 322 pos 16: '!name.contains('#')': is not true.
[ $compiler == dart2js && $fasta && $minified ]
arithmetic_test: CompileTimeError
