commit ecf5a46c96d5e8b8058badc0869878a572134514
author Jonas Termansen <sortie@google.com> Fri Mar 22 12:19:17 2019 +0000
committer Jonas Termansen <sortie@google.com> Fri Mar 22 12:19:17 2019 +0000
tree 0278f98dd2bdfb5c45b14fd67c4753081e3b6876
parent 849e914cb43ce9d33d2a463b9624b24780bdbda4

[infra] Fix approve_results crashing on approvals for deleted tests.

Change-Id: If269731bc7ac76d6ffd624eb02f51aed1f446d27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97624
Reviewed-by: William Hesse <whesse@google.com>

tools/approve_results.dart

diff --git a/tools/approve_results.dart b/tools/approve_results.dart
index 67554a7..1b105af 100755
--- a/tools/approve_results.dart
+++ b/tools/approve_results.dart
@@ -96,7 +96,7 @@
   String get baselineResult => (baselineData ?? const {})["result"];
   String get approvedResult => (approvedResultData ?? const {})["result"];
   bool get isDifferent => result != null && result != baselineResult;
-  bool get isApproved => result == approvedResult;
+  bool get isApproved => result == null || result == approvedResult;
   List<String> get flakyModes =>
       flakinessData != null ? flakinessData["outcomes"].cast<String>() : null;
   bool get isFlake => flakinessData != null && flakyModes.contains(result);