| // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file | |
| // for details. All rights reserved. Use of this source code is governed by a | |
| // BSD-style license that can be found in the LICENSE file. | |
| import 'package:analyzer/analysis_rule/analysis_rule.dart'; | |
| import 'package:analyzer/analysis_rule/rule_context.dart'; | |
| import 'package:analyzer/analysis_rule/rule_visitor_registry.dart'; | |
| import 'package:analyzer/dart/ast/ast.dart'; | |
| import 'package:analyzer/dart/ast/token.dart'; | |
| import 'package:analyzer/dart/ast/visitor.dart'; | |
| import 'package:analyzer/error/error.dart'; | |
| import '../analyzer.dart'; | |
| import '../diagnostic.dart' as diag; | |
| import '../extensions.dart'; | |
| import '../util/dart_type_utilities.dart' as type_utils; | |
| const _desc = r'Prefer using `??=` over testing for `null`.'; | |
| bool _checkExpression(Expression expression, Expression condition) => | |
| expression is AssignmentExpression && | |
| type_utils.canonicalElementsFromIdentifiersAreEqual( | |
| expression.leftHandSide, | |
| condition, | |
| ); | |
| bool _checkStatement(Statement statement, Expression condition) { | |
| if (statement is ExpressionStatement) { | |
| return _checkExpression(statement.expression, condition); | |
| } | |
| if (statement is Block && statement.statements.length == 1) { | |
| return _checkStatement(statement.statements.first, condition); | |
| } | |
| return false; | |
| } | |
| Expression? _getExpressionCondition(Expression rawExpression) { | |
| var expression = rawExpression.unParenthesized; | |
| if (expression is BinaryExpression && | |
| expression.operator.type == TokenType.EQ_EQ) { | |
| if (expression.rightOperand.isNullLiteral) { | |
| return expression.leftOperand; | |
| } | |
| if (expression.leftOperand.isNullLiteral) { | |
| return expression.rightOperand; | |
| } | |
| } | |
| return null; | |
| } | |
| class PreferConditionalAssignment extends AnalysisRule { | |
| new() | |
| : super(name: LintNames.prefer_conditional_assignment, description: _desc); | |
| @override | |
| DiagnosticCode get diagnosticCode => diag.preferConditionalAssignment; | |
| @override | |
| void registerNodeProcessors( | |
| RuleVisitorRegistry registry, | |
| RuleContext context, | |
| ) { | |
| var visitor = _Visitor(this); | |
| registry.addIfStatement(this, visitor); | |
| } | |
| } | |
| class _Visitor(final AnalysisRule rule) extends SimpleAstVisitor<void> { | |
| @override | |
| void visitIfStatement(IfStatement node) { | |
| if (node.elseStatement != null) { | |
| return; | |
| } | |
| var expressionInCondition = _getExpressionCondition(node.expression); | |
| if (expressionInCondition != null && | |
| _checkStatement(node.thenStatement, expressionInCondition)) { | |
| rule.reportAtNode(node); | |
| } | |
| } | |
| } |