commit e06ef81efa5ec8a69749c36cd04f89789d3fd62d
author Zach Anderson <zra@google.com> Fri Sep 21 21:00:40 2018 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Fri Sep 21 21:00:40 2018 +0000
tree 5695c4a4c72a9da70c42dcaa048384241168a4f9
parent 6a04b3079fe6bcf43687d65b182b1f493db7de1d

[vm] Unconditionally generate interpreter stubs

This allows building a core-jit snapshot that can support running with
--enable-interpreter even when the core-jit snapshot is not generated
with --enable-interpreter.

Change-Id: If6ce787baa9f11fef929ee496b54d68598cba520
Reviewed-on: https://dart-review.googlesource.com/75989
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Zach Anderson <zra@google.com>

runtime/vm/stub_code_arm64.cc

diff --git a/runtime/vm/stub_code_arm64.cc b/runtime/vm/stub_code_arm64.cc
index c63f0e8..91e88c0 100644
--- a/runtime/vm/stub_code_arm64.cc
+++ b/runtime/vm/stub_code_arm64.cc
@@ -1066,10 +1066,6 @@
 #if defined(DART_PRECOMPILED_RUNTIME)
   __ Stop("Not using interpreter");
 #else
-  if (!FLAG_enable_interpreter) {
-    __ Stop("Not using interpreter");
-    return;
-  }
   // Copy the C stack pointer (R31) into the stack pointer we'll actually use
   // to access the stack.
   __ SetupDartSP();
@@ -1992,11 +1988,6 @@
 #if defined(DART_PRECOMPILED_RUNTIME)
   __ Stop("Not using interpreter")
 #else
-  if (!FLAG_enable_interpreter) {
-    __ Stop("Not using interpreter");
-    return;
-  }
-
   __ SetPrologueOffset();
   __ EnterStubFrame();
 

runtime/vm/stub_code_x64.cc

diff --git a/runtime/vm/stub_code_x64.cc b/runtime/vm/stub_code_x64.cc
index f6a2790..c8cb6f1 100644
--- a/runtime/vm/stub_code_x64.cc
+++ b/runtime/vm/stub_code_x64.cc
@@ -979,10 +979,6 @@
 #if defined(DART_PRECOMPILED_RUNTIME)
   __ Stop("Not using interpreter");
 #else
-  if (!FLAG_enable_interpreter) {
-    __ Stop("Not using interpreter");
-    return;
-  }
   // Save frame pointer coming in.
   __ EnterFrame(0);
 
@@ -2008,10 +2004,6 @@
 #if defined(DART_PRECOMPILED_RUNTIME)
   __ Stop("Not using interpreter");
 #else
-  if (!FLAG_enable_interpreter) {
-    __ Stop("Not using interpreter");
-    return;
-  }
   __ EnterStubFrame();
 
 #if defined(DEBUG)