commit dce00bc836fd028231b81d1717062c77501351b7
author Devon Carew <devoncarew@google.com> Wed Jun 20 21:56:17 2018 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Wed Jun 20 21:56:17 2018 +0000
tree 8df2f1df816467d6df9d0981c127588e3523d8b6
parent 83a4d98554e28802043cbb19264165c9a1dcb886

- fix a strong mode type error
- mark a test as slow

Change-Id: I124c711e54b4bb4e3c7d68fb3a3f35be34be9151
Reviewed-on: https://dart-review.googlesource.com/61401
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>

pkg/analyzer/test/generated/package_build_test.dart

diff --git a/pkg/analyzer/test/generated/package_build_test.dart b/pkg/analyzer/test/generated/package_build_test.dart
index 47980a8..1cc46a6 100644
--- a/pkg/analyzer/test/generated/package_build_test.dart
+++ b/pkg/analyzer/test/generated/package_build_test.dart
@@ -477,7 +477,8 @@
       String root, List<String> packageNames) {
     final contextBuilder = new MockContextBuilder();
     final packages = new MockPackages();
-    final packageMap = new Map.fromIterable(packageNames, value: ((_) => []));
+    final packageMap = new Map<String, List<Folder>>.fromIterable(packageNames,
+        value: ((_) => []));
     contextBuilder.packagesMapMap[_p(root)] = packages;
     contextBuilder.packagesToMapMap[packages] = packageMap;
     return PackageBuildWorkspace.find(provider, _p(root), contextBuilder);

pkg/pkg.status

diff --git a/pkg/pkg.status b/pkg/pkg.status
index 7a258a5..cc1fb23 100644
--- a/pkg/pkg.status
+++ b/pkg/pkg.status
@@ -96,6 +96,7 @@
 kernel/test/*: RuntimeError, OK # Issue 26103. Timers are not supported.
 
 [ $runtime == vm ]
+analysis_server/test/benchmarks_test: Pass, Slow
 analysis_server/test/completion_test: Pass, Slow
 analysis_server/test/integration/analysis/error_test: Pass, Slow
 analysis_server/test/integration/analysis/lint_test: Pass, Slow
@@ -255,7 +256,6 @@
 front_end/tool/perf_test: Slow, Pass
 
 [ $runtime == vm && $checked ]
-analysis_server/test/benchmarks_test: Pass, Slow
 analysis_server/test/completion_test: Pass, Slow
 analysis_server/test/integration/edit/sort_members_test: Pass, Slow
 analysis_server/test/services/correction/fix_test: Pass, Slow