commit d4e2d78a94fe579fc80e604db47fe3b4cc62d8f8
author Ryan Macnak <rmacnak@google.com> Thu May 23 17:42:37 2019 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Thu May 23 17:42:37 2019 +0000
tree b77186cfef32aca0466bed44c1e299673de1a052
parent 338b74a52cf41459721f56f192d42eba42a486d2

[vm] Partially disable 5393ce7d35729e6a6b89e6e9316e99c15a8e3639.

Avoid flakily failures setting the thread signal mask.

Bug: https://github.com/dart-lang/sdk/issues/36908
Change-Id: I3d66214189f3276365b4c1cc333847cb4f65c94f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103400
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>

runtime/vm/os_thread_macos.cc

diff --git a/runtime/vm/os_thread_macos.cc b/runtime/vm/os_thread_macos.cc
index 50a2952..a0d050e 100644
--- a/runtime/vm/os_thread_macos.cc
+++ b/runtime/vm/os_thread_macos.cc
@@ -88,20 +88,6 @@
   DISALLOW_COPY_AND_ASSIGN(ThreadStartData);
 };
 
-// Spawned threads inherit their spawner's signal mask. We sometimes spawn
-// threads for running Dart code from a thread that is blocking SIGPROF.
-// This function explicitly unblocks SIGPROF so the profiler continues to
-// sample this thread.
-static void UnblockSIGPROF() {
-  sigset_t set;
-  sigemptyset(&set);
-  sigaddset(&set, SIGPROF);
-  int r = pthread_sigmask(SIG_UNBLOCK, &set, NULL);
-  USE(r);
-  ASSERT(r == 0);
-  ASSERT(!CHECK_IS_BLOCKING(SIGPROF));
-}
-
 // Dispatch to the thread start function provided by the caller. This trampoline
 // is used to ensure that the thread is properly destroyed if the thread just
 // exits.
@@ -121,7 +107,6 @@
   if (thread != NULL) {
     OSThread::SetCurrent(thread);
     thread->set_name(name);
-    UnblockSIGPROF();
     // Call the supplied thread start function handing it its parameters.
     function(parameter);
   }