[ DDS ] Fix devtools_server tests on Windows Fixes https://github.com/dart-lang/sdk/issues/48528 Change-Id: Iaa08d6ee409354eadc37d3beb98ea79b75575758 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239464 Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com> Commit-Queue: Ben Konyi <bkonyi@google.com>
diff --git a/pkg/dds/test/devtools_server/devtools_server_driver.dart b/pkg/dds/test/devtools_server/devtools_server_driver.dart index a5d44b8..9f56b81 100644 --- a/pkg/dds/test/devtools_server/devtools_server_driver.dart +++ b/pkg/dds/test/devtools_server/devtools_server_driver.dart
@@ -66,7 +66,7 @@ final script = Platform.script.resolveUri(Uri.parse('./serve_devtools.dart')); final args = [ - script.path, + script.toFilePath(), '--machine', '--port', '$port', @@ -202,7 +202,7 @@ Future<void> startApp() async { final appUri = Platform.script .resolveUri(Uri.parse('../fixtures/empty_dart_app.dart')); - appFixture = await CliAppFixture.create(appUri.path); + appFixture = await CliAppFixture.create(appUri.toFilePath()); // Track services method names as they're registered. appFixture.serviceConnection
diff --git a/pkg/dds/test/devtools_server/serve_devtools.dart b/pkg/dds/test/devtools_server/serve_devtools.dart index e44c4f8..7fbd12c 100644 --- a/pkg/dds/test/devtools_server/serve_devtools.dart +++ b/pkg/dds/test/devtools_server/serve_devtools.dart
@@ -12,7 +12,7 @@ unawaited( DevToolsServer().serveDevToolsWithArgs( args, - customDevToolsPath: devtoolsAppUri(prefix: '../../../../').path, + customDevToolsPath: devtoolsAppUri(prefix: '../../../../').toFilePath(), ), ); }
diff --git a/pkg/pkg.status b/pkg/pkg.status index 7122a64..2aef55f 100644 --- a/pkg/pkg.status +++ b/pkg/pkg.status
@@ -145,8 +145,6 @@ vm_snapshot_analysis/test/*: SkipByDesign # Only meant to run on vm [ $system == windows ] -dds/test/devtools_server/devtools_server_connection_test: Skip # Issue 48528 -dds/test/devtools_server/devtools_server_test: Skip # Issue 48528 front_end/test/fasta/bootstrap_test: Skip # Issue 31902 front_end/test/fasta/strong_test: Pass, Slow, Timeout front_end/test/fasta/text_serialization_test: Pass, Slow, Timeout