commit c8b28c4cf99a85825371708cddf14a842cde11b4
author Aart Bik <ajcbik@google.com> Wed Feb 13 00:38:13 2019 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Wed Feb 13 00:38:13 2019 +0000
tree a02ba4ddfcd556a33bd44b2070806e5c6f9665d1
parent f21fafd41185fc8dcf17a690c39995b0e9e8a4d4

[vm/compiler] graph checker addition

Rationale:
Loop part was not checking anything (no ASSERT).
Also, made test more strict (block should be
in all enveloping loops).
Change-Id: Ib918afa9c130dc8aa26cd8e8104e735075ff1176
Reviewed-on: https://dart-review.googlesource.com/c/92863
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>

runtime/vm/compiler/backend/flow_graph_checker.cc

diff --git a/runtime/vm/compiler/backend/flow_graph_checker.cc b/runtime/vm/compiler/backend/flow_graph_checker.cc
index b10e3f2..a07ed6d 100644
--- a/runtime/vm/compiler/backend/flow_graph_checker.cc
+++ b/runtime/vm/compiler/backend/flow_graph_checker.cc
@@ -137,9 +137,9 @@
   ASSERT(prev == last);
   // Make sure loop information, when up-to-date, agrees.
   if (flow_graph_->loop_hierarchy_ != nullptr) {
-    LoopInfo* loop = block->loop_info();
-    if (loop != nullptr) {
-      loop->Contains(block);
+    for (LoopInfo* loop = block->loop_info(); loop != nullptr;
+         loop = loop->outer()) {
+      ASSERT(loop->Contains(block));
     }
   }
 }