commit c4e308584ca1863e0c0fa167a75727fb2e71050c
author Paul Berry <paulberry@google.com> Mon Jun 17 22:03:07 2019 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Mon Jun 17 22:03:07 2019 +0000
tree a3d21e691ffac0f5a64f00d85ae4bfa94341b82f
parent df5e7aac17365b0bcca8fe6d4fb6c4838e2d67ba

Migration: unconditionally check guards in assertEdge

Change-Id: I882cbbb4dc6dce50a47255bff7ff2cc684d158d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>

pkg/nnbd_migration/test/migration_visitor_test.dart

diff --git a/pkg/nnbd_migration/test/migration_visitor_test.dart b/pkg/nnbd_migration/test/migration_visitor_test.dart
index 6633808..e7e51b5 100644
--- a/pkg/nnbd_migration/test/migration_visitor_test.dart
+++ b/pkg/nnbd_migration/test/migration_visitor_test.dart
@@ -1418,7 +1418,7 @@
 
   NullabilityEdge assertEdge(
       NullabilityNode source, NullabilityNode destination,
-      {@required bool hard, List<NullabilityNode> guards}) {
+      {@required bool hard, List<NullabilityNode> guards = const []}) {
     var edges = getEdges(source, destination);
     if (edges.length == 0) {
       fail('Expected edge $source -> $destination, found none');
@@ -1427,9 +1427,7 @@
     } else {
       var edge = edges[0];
       expect(edge.hard, hard);
-      if (guards != null) {
-        expect(edge.guards, unorderedEquals(guards));
-      }
+      expect(edge.guards, unorderedEquals(guards));
       return edge;
     }
   }