Remove redundant error notifications from LSP server
Change-Id: Ie2b4ac3c348835ad817cb34f24cc9b4108f1076d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101989
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
diff --git a/pkg/analysis_server/lib/src/lsp/lsp_analysis_server.dart b/pkg/analysis_server/lib/src/lsp/lsp_analysis_server.dart
index 6af0faf..031ba5d 100644
--- a/pkg/analysis_server/lib/src/lsp/lsp_analysis_server.dart
+++ b/pkg/analysis_server/lib/src/lsp/lsp_analysis_server.dart
@@ -343,9 +343,6 @@
if (message is RequestMessage) {
channel.sendResponse(
new ResponseMessage(message.id, null, error, jsonRpcVersion));
- // Since the LSP client might not show the failed requests to the user,
- // also ensure the error is logged to the client.
- logErrorToClient(error.message);
} else if (message is ResponseMessage) {
// For bad response messages where we can't respond with an error, send it as
// show instead of log.
diff --git a/pkg/analysis_server/test/lsp/initialization_test.dart b/pkg/analysis_server/test/lsp/initialization_test.dart
index 26b7028..aa19b1d 100644
--- a/pkg/analysis_server/test/lsp/initialization_test.dart
+++ b/pkg/analysis_server/test/lsp/initialization_test.dart
@@ -179,13 +179,10 @@
test_uninitialized_rejectsRequests() async {
final request = makeRequest(new Method.fromJson('randomRequest'), null);
- final logParams = await expectErrorNotification<LogMessageParams>(() async {
- final response = await channel.sendRequestToServer(request);
- expect(response.id, equals(request.id));
- expect(response.result, isNull);
- expect(response.error, isNotNull);
- expect(response.error.code, ErrorCodes.ServerNotInitialized);
- });
- expect(logParams.type, equals(MessageType.Error));
+ final response = await channel.sendRequestToServer(request);
+ expect(response.id, equals(request.id));
+ expect(response.result, isNull);
+ expect(response.error, isNotNull);
+ expect(response.error.code, ErrorCodes.ServerNotInitialized);
}
}
