blob: c7f7ea2fdd3ad4ab8817ac190109e63933d38b9f [file] [log] [blame]
// Copyright (c) 2018, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
import 'package:analyzer/analysis_rule/rule_context.dart';
import 'package:analyzer/analysis_rule/rule_visitor_registry.dart';
import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/ast/token.dart';
import 'package:analyzer/dart/ast/visitor.dart';
import 'package:analyzer/error/error.dart';
import '../analyzer.dart';
import '../ast.dart';
const _desc = r'Prefer `const` over `final` for declarations.';
class PreferConstDeclarations extends LintRule {
PreferConstDeclarations()
: super(name: LintNames.prefer_const_declarations, description: _desc);
@override
DiagnosticCode get diagnosticCode => LinterLintCode.preferConstDeclarations;
@override
void registerNodeProcessors(
RuleVisitorRegistry registry,
RuleContext context,
) {
var visitor = _Visitor(this);
registry.addFieldDeclaration(this, visitor);
registry.addTopLevelVariableDeclaration(this, visitor);
registry.addVariableDeclarationStatement(this, visitor);
}
}
class _Visitor extends SimpleAstVisitor<void> {
final LintRule rule;
_Visitor(this.rule);
@override
void visitFieldDeclaration(FieldDeclaration node) {
if (!node.isStatic) return;
_visitVariableDeclarationList(node.fields);
}
@override
void visitTopLevelVariableDeclaration(TopLevelVariableDeclaration node) =>
_visitVariableDeclarationList(node.variables);
@override
void visitVariableDeclarationStatement(VariableDeclarationStatement node) =>
_visitVariableDeclarationList(node.variables);
void _visitVariableDeclarationList(VariableDeclarationList node) {
if (node.isConst) return;
if (!node.isFinal) return;
if (node.variables.every((declaration) {
var initializer = declaration.initializer;
return initializer != null &&
(initializer is! TypedLiteral ||
(initializer.beginToken.keyword == Keyword.CONST)) &&
!hasConstantError(initializer);
})) {
rule.reportAtNode(node);
}
}
}