blob: 5e6fb06f2116850cccca92628e8e933d91c4fa07 [file] [log] [blame]
// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
import 'package:analyzer/analysis_rule/rule_context.dart';
import 'package:analyzer/analysis_rule/rule_visitor_registry.dart';
import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/ast/visitor.dart';
import 'package:analyzer/dart/element/element.dart';
import 'package:analyzer/dart/element/type.dart';
import 'package:analyzer/error/error.dart';
import '../analyzer.dart';
import '../extensions.dart';
const _desc = r'Avoid catches without on clauses.';
class AvoidCatchesWithoutOnClauses extends LintRule {
AvoidCatchesWithoutOnClauses()
: super(
name: LintNames.avoid_catches_without_on_clauses,
description: _desc,
);
@override
DiagnosticCode get diagnosticCode =>
LinterLintCode.avoidCatchesWithoutOnClauses;
@override
void registerNodeProcessors(
RuleVisitorRegistry registry,
RuleContext context,
) {
var visitor = _Visitor(this);
registry.addCatchClause(this, visitor);
}
}
class _CaughtExceptionUseVisitor extends RecursiveAstVisitor<void> {
final Element caughtException;
var exceptionWasUsed = false;
_CaughtExceptionUseVisitor(this.caughtException);
@override
void visitSimpleIdentifier(SimpleIdentifier node) {
if (node.element == caughtException) {
exceptionWasUsed = true;
}
}
}
class _ValidUseVisitor extends RecursiveAstVisitor<void> {
final Element caughtException;
bool hasValidUse = false;
var _canRethrow = true;
_ValidUseVisitor(this.caughtException);
@override
void visitCatchClause(CatchClause node) {
_canRethrow = false;
super.visitCatchClause(node);
}
@override
void visitFunctionExpressionInvocation(FunctionExpressionInvocation node) {
if (node.staticType is NeverType) {
_checkUseInArgument(node.argumentList);
return;
}
super.visitFunctionExpressionInvocation(node);
}
@override
void visitInstanceCreationExpression(InstanceCreationExpression node) {
if (node.constructorName.name?.name == 'error' &&
node.staticType.isSameAs('Future', 'dart.async')) {
_checkUseInArgument(node.argumentList);
}
super.visitInstanceCreationExpression(node);
}
@override
void visitMethodInvocation(MethodInvocation node) {
if (node.staticType is NeverType) {
_checkUseInArgument(node.argumentList);
} else if (node.methodName.name == 'reportError') {
var target = node.realTarget;
var targetElement = target is Identifier ? target.element : null;
if (targetElement is ClassElement &&
targetElement.name == 'FlutterError') {
_checkUseInArgument(node.argumentList);
}
} else if (node.methodName.name == 'completeError') {
var type = node.realTarget?.staticType;
if (type != null) {
if (type.extendsClass('Completer', 'dart.async')) {
_checkUseInArgument(node.argumentList);
}
}
}
super.visitMethodInvocation(node);
}
@override
void visitRethrowExpression(RethrowExpression node) {
hasValidUse = _canRethrow;
super.visitRethrowExpression(node);
}
@override
void visitThrowExpression(ThrowExpression node) {
var caughtExceptionUseVisitor = _CaughtExceptionUseVisitor(caughtException);
node.accept(caughtExceptionUseVisitor);
if (caughtExceptionUseVisitor.exceptionWasUsed) {
hasValidUse = true;
}
super.visitThrowExpression(node);
}
void _checkUseInArgument(ArgumentList node) {
// Check whether any argument has a reference to `caughtException`.
var caughtExceptionUseVisitor = _CaughtExceptionUseVisitor(caughtException);
node.accept(caughtExceptionUseVisitor);
if (caughtExceptionUseVisitor.exceptionWasUsed) {
hasValidUse = true;
}
}
}
class _Visitor extends SimpleAstVisitor<void> {
final LintRule rule;
_Visitor(this.rule);
@override
void visitCatchClause(CatchClause node) {
if (node.onKeyword != null) return;
var caughtException = node.exceptionParameter?.declaredFragment?.element;
if (caughtException == null) return;
var validUseVisitor = _ValidUseVisitor(caughtException);
node.body.accept(validUseVisitor);
if (validUseVisitor.hasValidUse) return;
var catchKeyword = node.catchKeyword;
if (catchKeyword == null) return;
rule.reportAtToken(catchKeyword);
}
}