blob: eb978176e9b9176be9cf94443963a3061f2e52a3 [file] [log] [blame]
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
import 'dart:io' show File;
import 'package:_fe_analyzer_shared/src/messages/severity.dart' show Severity;
import 'package:_fe_analyzer_shared/src/scanner/token.dart'
show KeywordToken, SimpleToken, Token;
import 'package:front_end/src/api_prototype/compiler_options.dart' as api
show DiagnosticMessage;
import 'package:front_end/src/fasta/builder/declaration_builders.dart'
show TypeDeclarationBuilder;
import 'package:front_end/src/fasta/builder/type_builder.dart' show TypeBuilder;
import 'package:front_end/src/fasta/fasta_codes.dart' as fasta
show templateUnspecified;
import 'package:front_end/src/fasta/kernel/body_builder.dart' show BodyBuilder;
import 'package:front_end/src/fasta/kernel/constness.dart' show Constness;
import 'package:front_end/src/fasta/kernel/expression_generator_helper.dart'
show UnresolvedKind;
import 'package:front_end/src/fasta/kernel/kernel_target.dart' show BuildResult;
import 'package:kernel/kernel.dart' show Arguments, Expression;
import 'compiler_test_helper.dart' show BodyBuilderTest, compile;
Set<Uri> _includedDirectoryUris = {};
Set<Uri> _ignoredDirectoryUris = {};
/// Run the explicit creation test (i.e. reporting missing 'new' tokens).
///
/// Explicitly compiles [includedFiles], reporting only errors for files in a
/// path in [includedDirectoryUris] and not in [ignoredDirectoryUris].
/// Note that this means that there can be reported errors in files not
/// explicitly included in [includedFiles], although that is not guaranteed.
///
/// Returns the number of errors found.
Future<int> runExplicitCreationTest(
{required Set<Uri> includedFiles,
required Set<Uri> includedDirectoryUris,
required Uri repoDir}) async {
_includedDirectoryUris.clear();
_includedDirectoryUris.addAll(includedDirectoryUris);
_ignoredDirectoryUris.clear();
_ignoredDirectoryUris
.add(repoDir.resolve("pkg/frontend_server/test/fixtures/"));
int errorCount = 0;
Uri packageConfigUri = repoDir.resolve(".dart_tool/package_config.json");
if (!new File.fromUri(packageConfigUri).existsSync()) {
throw "Couldn't find .dart_tool/package_config.json";
}
Set<Uri> includedFilesFiltered = {};
for (Uri uri in includedFiles) {
bool include = true;
for (Uri ignoredDir in _ignoredDirectoryUris) {
if (uri.toString().startsWith(ignoredDir.toString())) {
include = false;
break;
}
}
if (include) {
includedFilesFiltered.add(uri);
}
}
Stopwatch stopwatch = new Stopwatch()..start();
// TODO(jensj): While we need to compile the outline as normal, it should be
// sufficient to compile the body of the paths mentioned in [includedFiles].
// TODO(jensj): The target has to be VM or we can't compile the sdk,
// but probably we don't actually need to run any vm-specific transformations
// for instance.
BuildResult result = await compile(
inputs: includedFilesFiltered.toList(),
// Compile sdk because when this is run from a lint it uses the checked-in
// sdk and we might not have a suitable compiled platform.dill file.
compileSdk: true,
packagesFileUri: packageConfigUri,
onDiagnostic: (api.DiagnosticMessage message) {
if (message.severity == Severity.error) {
print(message.plainTextFormatted.join('\n'));
errorCount++;
}
},
repoDir: repoDir,
bodyBuilderCreator: (
create: BodyBuilderTester.new,
createForField: BodyBuilderTester.forField,
createForOutlineExpression: BodyBuilderTester.forOutlineExpression
),
splitCompileAndCompileLess: true);
print("Done in ${stopwatch.elapsedMilliseconds} ms. "
"Found $errorCount errors.");
print("Compiled ${result.component?.libraries.length} libraries.");
return errorCount;
}
class BodyBuilderTester = BodyBuilderTest with BodyBuilderTestMixin;
mixin BodyBuilderTestMixin on BodyBuilder {
@override
Expression buildConstructorInvocation(
TypeDeclarationBuilder? type,
Token nameToken,
Token nameLastToken,
Arguments? arguments,
String name,
List<TypeBuilder>? typeArguments,
int charOffset,
Constness constness,
{bool isTypeArgumentsInForest = false,
TypeDeclarationBuilder? typeAliasBuilder,
required UnresolvedKind unresolvedKind}) {
Token maybeNewOrConst = nameToken.previous!;
bool doReport = true;
if (maybeNewOrConst is KeywordToken) {
if (maybeNewOrConst.lexeme == "new" ||
maybeNewOrConst.lexeme == "const") {
doReport = false;
}
} else if (maybeNewOrConst is SimpleToken) {
if (maybeNewOrConst.lexeme == "@") {
doReport = false;
}
}
if (doReport) {
bool match = false;
for (Uri libUri in _includedDirectoryUris) {
if (uri.toString().startsWith(libUri.toString())) {
match = true;
break;
}
}
if (match) {
for (Uri libUri in _ignoredDirectoryUris) {
if (uri.toString().startsWith(libUri.toString())) {
match = false;
break;
}
}
}
if (!match) {
doReport = false;
}
}
if (doReport) {
addProblem(
fasta.templateUnspecified.withArguments("Should use new or const"),
nameToken.charOffset,
nameToken.length);
}
return super.buildConstructorInvocation(type, nameToken, nameLastToken,
arguments, name, typeArguments, charOffset, constness,
isTypeArgumentsInForest: isTypeArgumentsInForest,
unresolvedKind: unresolvedKind);
}
}