Add support for lints to visit the new AST nodes
Change-Id: I5470b7b596995ebd3c86eb2ef31561b960a5d321
Reviewed-on: https://dart-review.googlesource.com/c/90780
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
diff --git a/pkg/analyzer/lib/src/lint/linter_visitor.dart b/pkg/analyzer/lib/src/lint/linter_visitor.dart
index 7b2374e..54d81f6 100644
--- a/pkg/analyzer/lib/src/lint/linter_visitor.dart
+++ b/pkg/analyzer/lib/src/lint/linter_visitor.dart
@@ -109,6 +109,18 @@
}
@override
+ void visitCollectionForElement(CollectionForElement node) {
+ _runSubscriptions(node, registry._forCollectionForElement);
+ super.visitCollectionForElement(node);
+ }
+
+ @override
+ void visitCollectionIfElement(CollectionIfElement node) {
+ _runSubscriptions(node, registry._forCollectionIfElement);
+ super.visitCollectionIfElement(node);
+ }
+
+ @override
void visitComment(Comment node) {
_runSubscriptions(node, registry._forComment);
super.visitComment(node);
@@ -253,6 +265,18 @@
}
@override
+ void visitForEachPartsWithDeclaration(ForEachPartsWithDeclaration node) {
+ _runSubscriptions(node, registry._forForEachPartsWithDeclaration);
+ super.visitForEachPartsWithDeclaration(node);
+ }
+
+ @override
+ void visitForEachPartsWithIdentifier(ForEachPartsWithIdentifier node) {
+ _runSubscriptions(node, registry._forForEachPartsWithIdentifier);
+ super.visitForEachPartsWithIdentifier(node);
+ }
+
+ @override
void visitForEachStatement(ForEachStatement node) {
_runSubscriptions(node, registry._forForEachStatement);
super.visitForEachStatement(node);
@@ -265,12 +289,30 @@
}
@override
+ void visitForPartsWithDeclarations(ForPartsWithDeclarations node) {
+ _runSubscriptions(node, registry._forForPartsWithDeclarations);
+ super.visitForPartsWithDeclarations(node);
+ }
+
+ @override
+ void visitForPartsWithExpression(ForPartsWithExpression node) {
+ _runSubscriptions(node, registry._forForPartsWithExpression);
+ super.visitForPartsWithExpression(node);
+ }
+
+ @override
void visitForStatement(ForStatement node) {
_runSubscriptions(node, registry._forForStatement);
super.visitForStatement(node);
}
@override
+ void visitForStatement2(ForStatement2 node) {
+ _runSubscriptions(node, registry._forForStatement2);
+ super.visitForStatement2(node);
+ }
+
+ @override
void visitFunctionDeclaration(FunctionDeclaration node) {
_runSubscriptions(node, registry._forFunctionDeclaration);
super.visitFunctionDeclaration(node);
@@ -409,12 +451,36 @@
}
@override
+ void visitListLiteral2(ListLiteral2 node) {
+ _runSubscriptions(node, registry._forListLiteral2);
+ super.visitListLiteral2(node);
+ }
+
+ @override
+ void visitMapForElement(MapForElement node) {
+ _runSubscriptions(node, registry._forMapForElement);
+ super.visitMapForElement(node);
+ }
+
+ @override
+ void visitMapIfElement(MapIfElement node) {
+ _runSubscriptions(node, registry._forMapIfElement);
+ super.visitMapIfElement(node);
+ }
+
+ @override
void visitMapLiteral(MapLiteral node) {
_runSubscriptions(node, registry._forMapLiteral);
super.visitMapLiteral(node);
}
@override
+ void visitMapLiteral2(MapLiteral2 node) {
+ _runSubscriptions(node, registry._forMapLiteral2);
+ super.visitMapLiteral2(node);
+ }
+
+ @override
void visitMapLiteralEntry(MapLiteralEntry node) {
_runSubscriptions(node, registry._forMapLiteralEntry);
super.visitMapLiteralEntry(node);
@@ -518,6 +584,12 @@
}
@override
+ void visitSetLiteral2(SetLiteral2 node) {
+ _runSubscriptions(node, registry._forSetLiteral2);
+ super.visitSetLiteral2(node);
+ }
+
+ @override
void visitShowCombinator(ShowCombinator node) {
_runSubscriptions(node, registry._forShowCombinator);
super.visitShowCombinator(node);
@@ -542,6 +614,12 @@
}
@override
+ void visitSpreadElement(SpreadElement node) {
+ _runSubscriptions(node, registry._forSpreadElement);
+ super.visitSpreadElement(node);
+ }
+
+ @override
void visitStringInterpolation(StringInterpolation node) {
_runSubscriptions(node, registry._forStringInterpolation);
super.visitStringInterpolation(node);
@@ -701,6 +779,8 @@
final List<_Subscription<CatchClause>> _forCatchClause = [];
final List<_Subscription<ClassDeclaration>> _forClassDeclaration = [];
final List<_Subscription<ClassTypeAlias>> _forClassTypeAlias = [];
+ final List<_Subscription<CollectionForElement>> _forCollectionForElement = [];
+ final List<_Subscription<CollectionIfElement>> _forCollectionIfElement = [];
final List<_Subscription<Comment>> _forComment = [];
final List<_Subscription<CommentReference>> _forCommentReference = [];
final List<_Subscription<CompilationUnit>> _forCompilationUnit = [];
@@ -731,9 +811,18 @@
final List<_Subscription<ExtendsClause>> _forExtendsClause = [];
final List<_Subscription<FieldDeclaration>> _forFieldDeclaration = [];
final List<_Subscription<FieldFormalParameter>> _forFieldFormalParameter = [];
+ final List<_Subscription<ForEachPartsWithDeclaration>>
+ _forForEachPartsWithDeclaration = [];
+ final List<_Subscription<ForEachPartsWithIdentifier>>
+ _forForEachPartsWithIdentifier = [];
final List<_Subscription<ForEachStatement>> _forForEachStatement = [];
final List<_Subscription<FormalParameterList>> _forFormalParameterList = [];
+ final List<_Subscription<ForPartsWithDeclarations>>
+ _forForPartsWithDeclarations = [];
+ final List<_Subscription<ForPartsWithExpression>> _forForPartsWithExpression =
+ [];
final List<_Subscription<ForStatement>> _forForStatement = [];
+ final List<_Subscription<ForStatement2>> _forForStatement2 = [];
final List<_Subscription<FunctionDeclaration>> _forFunctionDeclaration = [];
final List<_Subscription<FunctionDeclarationStatement>>
_forFunctionDeclarationStatement = [];
@@ -762,7 +851,11 @@
final List<_Subscription<LibraryDirective>> _forLibraryDirective = [];
final List<_Subscription<LibraryIdentifier>> _forLibraryIdentifier = [];
final List<_Subscription<ListLiteral>> _forListLiteral = [];
+ final List<_Subscription<ListLiteral2>> _forListLiteral2 = [];
+ final List<_Subscription<MapForElement>> _forMapForElement = [];
+ final List<_Subscription<MapIfElement>> _forMapIfElement = [];
final List<_Subscription<MapLiteral>> _forMapLiteral = [];
+ final List<_Subscription<MapLiteral2>> _forMapLiteral2 = [];
final List<_Subscription<MapLiteralEntry>> _forMapLiteralEntry = [];
final List<_Subscription<MethodDeclaration>> _forMethodDeclaration = [];
final List<_Subscription<MethodInvocation>> _forMethodInvocation = [];
@@ -782,11 +875,13 @@
_forRedirectingConstructorInvocation = [];
final List<_Subscription<RethrowExpression>> _forRethrowExpression = [];
final List<_Subscription<ReturnStatement>> _forReturnStatement = [];
+ final List<_Subscription<SetLiteral2>> _forSetLiteral2 = [];
final List<_Subscription<ShowCombinator>> _forShowCombinator = [];
final List<_Subscription<SimpleFormalParameter>> _forSimpleFormalParameter =
[];
final List<_Subscription<SimpleIdentifier>> _forSimpleIdentifier = [];
final List<_Subscription<SimpleStringLiteral>> _forSimpleStringLiteral = [];
+ final List<_Subscription<SpreadElement>> _forSpreadElement = [];
final List<_Subscription<StringInterpolation>> _forStringInterpolation = [];
final List<_Subscription<SuperConstructorInvocation>>
_forSuperConstructorInvocation = [];
@@ -886,6 +981,16 @@
.add(new _Subscription(linter, visitor, _getTimer(linter)));
}
+ void addCollectionForElement(LintRule linter, AstVisitor visitor) {
+ _forCollectionForElement
+ .add(new _Subscription(linter, visitor, _getTimer(linter)));
+ }
+
+ void addCollectionIfElement(LintRule linter, AstVisitor visitor) {
+ _forCollectionIfElement
+ .add(new _Subscription(linter, visitor, _getTimer(linter)));
+ }
+
void addComment(LintRule linter, AstVisitor visitor) {
_forComment.add(new _Subscription(linter, visitor, _getTimer(linter)));
}
@@ -1003,6 +1108,16 @@
.add(new _Subscription(linter, visitor, _getTimer(linter)));
}
+ void addForEachPartsWithDeclaration(LintRule linter, AstVisitor visitor) {
+ _forForEachPartsWithDeclaration
+ .add(new _Subscription(linter, visitor, _getTimer(linter)));
+ }
+
+ void addForEachPartsWithIdentifier(LintRule linter, AstVisitor visitor) {
+ _forForEachPartsWithIdentifier
+ .add(new _Subscription(linter, visitor, _getTimer(linter)));
+ }
+
void addForEachStatement(LintRule linter, AstVisitor visitor) {
_forForEachStatement
.add(new _Subscription(linter, visitor, _getTimer(linter)));
@@ -1013,10 +1128,25 @@
.add(new _Subscription(linter, visitor, _getTimer(linter)));
}
+ void addForPartsWithDeclarations(LintRule linter, AstVisitor visitor) {
+ _forForPartsWithDeclarations
+ .add(new _Subscription(linter, visitor, _getTimer(linter)));
+ }
+
+ void addForPartsWithExpression(LintRule linter, AstVisitor visitor) {
+ _forForPartsWithExpression
+ .add(new _Subscription(linter, visitor, _getTimer(linter)));
+ }
+
void addForStatement(LintRule linter, AstVisitor visitor) {
_forForStatement.add(new _Subscription(linter, visitor, _getTimer(linter)));
}
+ void addForStatement2(LintRule linter, AstVisitor visitor) {
+ _forForStatement2
+ .add(new _Subscription(linter, visitor, _getTimer(linter)));
+ }
+
void addFunctionDeclaration(LintRule linter, AstVisitor visitor) {
_forFunctionDeclaration
.add(new _Subscription(linter, visitor, _getTimer(linter)));
@@ -1128,10 +1258,27 @@
_forListLiteral.add(new _Subscription(linter, visitor, _getTimer(linter)));
}
+ void addListLiteral2(LintRule linter, AstVisitor visitor) {
+ _forListLiteral2.add(new _Subscription(linter, visitor, _getTimer(linter)));
+ }
+
+ void addMapForElement(LintRule linter, AstVisitor visitor) {
+ _forMapForElement
+ .add(new _Subscription(linter, visitor, _getTimer(linter)));
+ }
+
+ void addMapIfElement(LintRule linter, AstVisitor visitor) {
+ _forMapIfElement.add(new _Subscription(linter, visitor, _getTimer(linter)));
+ }
+
void addMapLiteral(LintRule linter, AstVisitor visitor) {
_forMapLiteral.add(new _Subscription(linter, visitor, _getTimer(linter)));
}
+ void addMapLiteral2(LintRule linter, AstVisitor visitor) {
+ _forMapLiteral2.add(new _Subscription(linter, visitor, _getTimer(linter)));
+ }
+
void addMapLiteralEntry(LintRule linter, AstVisitor visitor) {
_forMapLiteralEntry
.add(new _Subscription(linter, visitor, _getTimer(linter)));
@@ -1216,6 +1363,10 @@
.add(new _Subscription(linter, visitor, _getTimer(linter)));
}
+ void addSetLiteral2(LintRule linter, AstVisitor visitor) {
+ _forSetLiteral2.add(new _Subscription(linter, visitor, _getTimer(linter)));
+ }
+
void addShowCombinator(LintRule linter, AstVisitor visitor) {
_forShowCombinator
.add(new _Subscription(linter, visitor, _getTimer(linter)));
@@ -1236,6 +1387,11 @@
.add(new _Subscription(linter, visitor, _getTimer(linter)));
}
+ void addSpreadElement(LintRule linter, AstVisitor visitor) {
+ _forSpreadElement
+ .add(new _Subscription(linter, visitor, _getTimer(linter)));
+ }
+
void addStringInterpolation(LintRule linter, AstVisitor visitor) {
_forStringInterpolation
.add(new _Subscription(linter, visitor, _getTimer(linter)));
