[infra] Fix approve_results deleting existing meta-information.
Change-Id: I585344cdf13d8cde93b0eba8e850d436a11c9200
Reviewed-on: https://dart-review.googlesource.com/c/91200
Reviewed-by: William Hesse <whesse@google.com>
diff --git a/tools/approve_results.dart b/tools/approve_results.dart
index 7c31274..4962072 100755
--- a/tools/approve_results.dart
+++ b/tools/approve_results.dart
@@ -684,12 +684,14 @@
final futures = <Future>[];
for (final String bot in unapprovedBots) {
Map<String, dynamic> approveData(Test test) {
- final data = new Map<String, dynamic>.from(test.resultData);
- if (!test.isApproved) {
+ if (test.isApproved) {
+ return test.approvedResultData;
+ } else {
+ final data = new Map<String, dynamic>.from(test.resultData);
data["approver"] = username;
data["approved_at"] = now;
+ return data;
}
- return data;
}
final dataList = testsForBots[bot].map(approveData).toList();
