[ VM / Service ] Fixed issue where VMOptions were not being passed to app_jitk tests.
Fixes #35512.
Change-Id: I34abbf0f73215b6695a0aa4ec6af6cb1c219d5e9
Reviewed-on: https://dart-review.googlesource.com/c/88429
Auto-Submit: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
diff --git a/runtime/observatory/tests/service/service_kernel.status b/runtime/observatory/tests/service/service_kernel.status
index 8c902b1..3b35e4f 100644
--- a/runtime/observatory/tests/service/service_kernel.status
+++ b/runtime/observatory/tests/service/service_kernel.status
@@ -29,13 +29,10 @@
get_retained_size_rpc_test: SkipByDesign # No incremental compiler available.
get_retaining_path_rpc_test: SkipByDesign # No incremental compiler available.
get_user_level_retaining_path_rpc_test: SkipByDesign # No incremental compiler available.
-get_vm_rpc_test: RuntimeError # Issue 35512 VMOptions=--vm-name=Walter not recognized when running from snapshot.
-get_vm_timeline_rpc_test: RuntimeError
instance_field_order_rpc_test: SkipByDesign # No incremental compiler available.
pause_on_exceptions_test: SkipByDesign # No incremental compiler available.
rewind_optimized_out_test: SkipByDesign # No incremental compiler available.
rewind_test: SkipByDesign # No incremental compiler available.
-set_vm_name_rpc_test: RuntimeError # Issue 35512 VMOptions=--vm-name=Walter not recognized when running from snapshot.
simple_reload_test: RuntimeError, Timeout # Issue 35506
unused_changes_in_last_reload_test: RuntimeError
diff --git a/tests/language_2/language_2_kernel.status b/tests/language_2/language_2_kernel.status
index 292b4c8..8047938 100644
--- a/tests/language_2/language_2_kernel.status
+++ b/tests/language_2/language_2_kernel.status
@@ -142,6 +142,7 @@
type_promotion_functions_test/none: CompileTimeError
type_promotion_more_specific_test/04: CompileTimeError
vm/bool_check_stack_traces_test/02: RuntimeError # Issue 33584
+vm/regress_27671_test: SkipByDesign # Relies on string comparison of exception message which may return '<optimized out>'
vm/type_cast_vm_test: RuntimeError
web_int_literals_test/*: SkipByDesign # Test applies only to JavaScript targets
@@ -272,9 +273,6 @@
vm/causal_async_exception_stack2_test: RuntimeError
vm/causal_async_exception_stack_test: RuntimeError
-[ $compiler == app_jitk && ($mode == debug || $mode == release) ]
-assertion_test: RuntimeError
-
[ $compiler != app_jitk && $compiler != dart2analyzer && $compiler != dart2js && $compiler != dartk && $compiler != dartkb && $compiler != dartkp && $fasta ]
const_optional_args_test/01: MissingCompileTimeError
diff --git a/tests/standalone_2/standalone_2_kernel.status b/tests/standalone_2/standalone_2_kernel.status
index 39e062c..f073ec4 100644
--- a/tests/standalone_2/standalone_2_kernel.status
+++ b/tests/standalone_2/standalone_2_kernel.status
@@ -33,8 +33,6 @@
io/web_socket_pipe_test: RuntimeError
io/web_socket_protocol_processor_test: CompileTimeError
io/zlib_test: RuntimeError
-oom_error_stacktrace_test: RuntimeError
-out_of_memory_test: RuntimeError
[ $compiler == dartkp ]
io/test_runner_test: SkipByDesign # Is not relevant for AOT.
@@ -65,9 +63,6 @@
[ $builder_tag == optimization_counter_threshold && ($compiler == dartk || $compiler == dartkb) ]
map_insert_remove_oom_test: Skip # Heap limit too low.
-[ $compiler == app_jitk && ($mode == debug || $mode == release) ]
-dart_developer_disabled_env_test: RuntimeError
-
# The failures below still need to be investigated and possibly fixed, or marked as skipped.
[ $compiler == dartkb && $strong ]
io/code_collection_test: RuntimeError # Reruns the same script (dill file without AST) without passing --enable-interpreter or --use-bytecode-compiler.
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index b960471..4cecd58 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -1449,7 +1449,8 @@
Compiler.dartkb,
Compiler.dartkp,
Compiler.precompiler,
- Compiler.appJit
+ Compiler.appJit,
+ Compiler.appJitk,
];
const runtimes = const [Runtime.none, Runtime.dartPrecompiled, Runtime.vm];
