Have dart2analyzer no longer use the --no-preview-dart-2 flag in test.py.
Change-Id: I73266243f7819cda9e46bc354bc87d3ee9da9a15
Reviewed-on: https://dart-review.googlesource.com/63695
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: William Hesse <whesse@google.com>
diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart
index c077166..689bd12 100644
--- a/tools/testing/dart/compiler_configuration.dart
+++ b/tools/testing/dart/compiler_configuration.dart
@@ -1003,8 +1003,7 @@
arguments.add('--enable_type_checks');
}
if (!previewDart2) {
- arguments.add('--no-preview-dart-2');
- arguments.add('--no-strong');
+ throw new ArgumentError('--no-preview-dart-2 not supported');
}
if (_configuration.useAnalyzerCfe) {
arguments.add('--use-cfe');
diff --git a/tools/testing/dart/options.dart b/tools/testing/dart/options.dart
index 4b76075..aa4b0bf 100644
--- a/tools/testing/dart/options.dart
+++ b/tools/testing/dart/options.dart
@@ -176,8 +176,8 @@
'Only run tests that are not marked `Slow` or `Timeout`.'),
new _Option.bool('enable_asserts',
'Pass the --enable-asserts flag to dart2js or to the vm.'),
- new _Option.bool(
- 'no_preview_dart_2', 'Pass the --no-preview-dart-2 flag to analyzer',
+ new _Option.bool('no_preview_dart_2',
+ 'Enable legacy Dart 1 behavior for some runtimes and compilers.',
hide: true),
new _Option.bool('use_cfe', 'Pass the --use-cfe flag to analyzer',
hide: true),
@@ -248,8 +248,7 @@
new _Option('output_directory',
'The name of the output directory for storing log files.',
defaultsTo: "logs", hide: true),
- new _Option.bool('noBatch', 'Do not run tests in batch mode.',
- hide: true),
+ new _Option.bool('noBatch', 'Do not run tests in batch mode.', hide: true),
new _Option.bool('dart2js_batch', 'Run dart2js tests in batch mode.',
hide: true),
new _Option.bool(
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 1ef561d..d17dec7 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -1298,11 +1298,6 @@
filePath.directoryPath.segments().last.contains('html_common')) {
args.add("--use-dart2js-libraries");
}
- if (configuration.noPreviewDart2) {
- args.add("--no-preview-dart-2");
- } else {
- args.add("--preview-dart-2");
- }
}
if (configuration.compiler == Compiler.dart2js) {
