| commit | a3073fc5818963879515f35a7acaf700fefb0d33 | [log] [tgz] |
|---|---|---|
| author | Mike Fairhurst <mfairhurst@google.com> | Tue May 14 22:24:34 2019 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Tue May 14 22:24:34 2019 +0000 |
| tree | 241a7630acfd618aaa502528a7050e3500e222d3 | |
| parent | ebaf0ad8b1490b8e941e08a97eb44d43ed411a83 [diff] |
check null condition in assert Change-Id: I4de11a7de3e5106ce9d5fbaf89d0b0965d637b08 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102221 Auto-Submit: Mike Fairhurst <mfairhurst@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
diff --git a/pkg/analyzer/lib/src/generated/error_verifier.dart b/pkg/analyzer/lib/src/generated/error_verifier.dart index 6792bc6..a5e2927 100644 --- a/pkg/analyzer/lib/src/generated/error_verifier.dart +++ b/pkg/analyzer/lib/src/generated/error_verifier.dart
@@ -365,12 +365,14 @@ @override void visitAssertInitializer(AssertInitializer node) { _checkForNonBoolExpression(node); + _checkForNullableDereference(node.condition); super.visitAssertInitializer(node); } @override void visitAssertStatement(AssertStatement node) { _checkForNonBoolExpression(node); + _checkForNullableDereference(node.condition); super.visitAssertStatement(node); }
diff --git a/tests/language_2/nnbd/static_errors/unchecked_use_of_nullable_test.dart b/tests/language_2/nnbd/static_errors/unchecked_use_of_nullable_test.dart index e88f9ed..a991f55 100644 --- a/tests/language_2/nnbd/static_errors/unchecked_use_of_nullable_test.dart +++ b/tests/language_2/nnbd/static_errors/unchecked_use_of_nullable_test.dart
@@ -53,9 +53,10 @@ x?.round(); //# 35: ok for(i in list) {}; //# 36: compile-time error await for(i in stream) {}; //# 37: compile-time error + assert(cond); //# 38: compile-time error } generator() sync* { Iterable? iter; - yield* iter; //# 38: compile-time error + yield* iter; //# 39: compile-time error }