Improve the highlight range for ambiguous_export
Change-Id: I0c4f887ad467fa5e186ad34650816f15956f623f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170021
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
diff --git a/pkg/analyzer/lib/src/generated/error_verifier.dart b/pkg/analyzer/lib/src/generated/error_verifier.dart
index ba0c30b..17fee72 100644
--- a/pkg/analyzer/lib/src/generated/error_verifier.dart
+++ b/pkg/analyzer/lib/src/generated/error_verifier.dart
@@ -1494,7 +1494,7 @@
Element prevElement = _exportedElements[name];
if (element != null && prevElement != null && prevElement != element) {
_errorReporter.reportErrorForNode(
- CompileTimeErrorCode.AMBIGUOUS_EXPORT, directive, [
+ CompileTimeErrorCode.AMBIGUOUS_EXPORT, directive.uri, [
name,
prevElement.library.definingCompilationUnit.source.uri,
element.library.definingCompilationUnit.source.uri
diff --git a/pkg/analyzer/test/src/diagnostics/ambiguous_export_test.dart b/pkg/analyzer/test/src/diagnostics/ambiguous_export_test.dart
index 17142d7..b22efa2 100644
--- a/pkg/analyzer/test/src/diagnostics/ambiguous_export_test.dart
+++ b/pkg/analyzer/test/src/diagnostics/ambiguous_export_test.dart
@@ -26,7 +26,7 @@
export 'lib1.dart';
export 'lib2.dart';
''', [
- error(CompileTimeErrorCode.AMBIGUOUS_EXPORT, 20, 19),
+ error(CompileTimeErrorCode.AMBIGUOUS_EXPORT, 27, 11),
]);
}
@@ -41,7 +41,7 @@
export 'lib1.dart';
export 'lib2.dart';
''', [
- error(CompileTimeErrorCode.AMBIGUOUS_EXPORT, 20, 19),
+ error(CompileTimeErrorCode.AMBIGUOUS_EXPORT, 27, 11),
]);
}
