Remove variableSet factory methods.

It turns out they aren't needed--the required functionality is already
provided by the variableAssign method.

Fixes #33557.

Change-Id: Ieb3cfc237a6d7d6ae61f0afcd9e9bb9ead1c8fbb
Reviewed-on: https://dart-review.googlesource.com/62125
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
diff --git a/pkg/analyzer/lib/src/fasta/resolution_storer.dart b/pkg/analyzer/lib/src/fasta/resolution_storer.dart
index 7eeefb0..e0b2de8 100644
--- a/pkg/analyzer/lib/src/fasta/resolution_storer.dart
+++ b/pkg/analyzer/lib/src/fasta/resolution_storer.dart
@@ -664,13 +664,6 @@
         inferredType: inferredType);
   }
 
-  void variableSet(
-          ExpressionJudgment judgment,
-          Location location,
-          covariant VariableDeclarationBinder variableBinder,
-          DartType inferredType) =>
-      genericExpression("variableSet", location, inferredType);
-
   void whileStatement(
       StatementJudgment judgment,
       Location location,
diff --git a/pkg/front_end/lib/src/fasta/kernel/factory.dart b/pkg/front_end/lib/src/fasta/kernel/factory.dart
index 177480f..9995d68 100644
--- a/pkg/front_end/lib/src/fasta/kernel/factory.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/factory.dart
@@ -436,9 +436,6 @@
   Expression variableGet(ExpressionJudgment judgment, int fileOffset,
       bool isInCascade, covariant Object variableBinder, DartType inferredType);
 
-  Expression variableSet(ExpressionJudgment judgment, int fileOffset,
-      covariant Object variableBinder, DartType inferredType);
-
   Statement whileStatement(
       StatementJudgment judgment,
       int fileOffset,
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_factory.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_factory.dart
index 30255bc..33c6f13 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_factory.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_factory.dart
@@ -668,12 +668,6 @@
   }
 
   @override
-  Expression variableSet(ExpressionJudgment judgment, int fileOffset,
-      covariant VariableDeclaration variableBinder, DartType inferredType) {
-    return judgment;
-  }
-
-  @override
   Statement whileStatement(
       StatementJudgment judgment,
       int fileOffset,
diff --git a/pkg/front_end/lib/src/fasta/kernel/toplevel_inference_factory.dart b/pkg/front_end/lib/src/fasta/kernel/toplevel_inference_factory.dart
index 7fd818c..ee0bbb2 100644
--- a/pkg/front_end/lib/src/fasta/kernel/toplevel_inference_factory.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/toplevel_inference_factory.dart
@@ -501,10 +501,6 @@
       bool isInCascade, covariant void variableBinder, DartType inferredType) {}
 
   @override
-  void variableSet(ExpressionJudgment judgment, int fileOffset,
-      covariant void variableBinder, DartType inferredType) {}
-
-  @override
   void whileStatement(
       StatementJudgment judgment,
       int fileOffset,
diff --git a/pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart b/pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart
index 3c96da9..2440504 100644
--- a/pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart
+++ b/pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart
@@ -435,9 +435,6 @@
   void variableGet(ExpressionJudgment judgment, Location location,
       bool isInCascade, covariant Object variableBinder, DartType inferredType);
 
-  void variableSet(ExpressionJudgment judgment, Location location,
-      covariant Object variableBinder, DartType inferredType);
-
   void whileStatement(
       StatementJudgment judgment,
       Location location,
@@ -907,10 +904,6 @@
       expressionVariable, DartType inferredType) {}
 
   @override
-  void variableSet(ExpressionJudgment judgment, location,
-      covariant void variableBinder, DartType inferredType) {}
-
-  @override
   void whileStatement(
       StatementJudgment judgment,
       location,