commit 94abf948c440442b2cbfea81fe77d9bed50e877f
author Kevin Moore <kevmoo@google.com> Fri Jun 22 16:42:27 2018 +0000
committer Kevin Moore <kevmoo@google.com> Fri Jun 22 16:42:27 2018 +0000
tree 3f458fb71a5307618afd1a76fe3a815adc1bae3e
parent 02721709c3a447289f91621bde8c114bd060ea78

pkg:status_file misc cleanup

Clarify in the pubspec that it's not published
Cleaned up hints/lints in source files

Change-Id: Ifbf59ab0fb219dcdf5de99eced0a0129e6e191cb
Reviewed-on: https://dart-review.googlesource.com/61909
Reviewed-by: Bob Nystrom <rnystrom@google.com>

pkg/status_file/bin/lint.dart

diff --git a/pkg/status_file/bin/lint.dart b/pkg/status_file/bin/lint.dart
index d7e985d..17b84f47 100644
--- a/pkg/status_file/bin/lint.dart
+++ b/pkg/status_file/bin/lint.dart
@@ -62,7 +62,7 @@
     while (null != (readString = stdin.readLineSync())) {
       strings.add(readString);
     }
-  } on StdinException catch (e) {
+  } on StdinException {
     // I do not know why this happens.
   }
   if (!lintText(strings)) {
@@ -100,7 +100,7 @@
     var statusFile = new StatusFile.parse("stdin", text);
     return lintStatusFile(statusFile,
         checkForDisjunctions: checkForDisjunctions);
-  } on status_file.SyntaxError catch (error) {
+  } on status_file.SyntaxError {
     stderr.writeln("Could not parse stdin.");
   }
   return false;

pkg/status_file/pubspec.yaml

diff --git a/pkg/status_file/pubspec.yaml b/pkg/status_file/pubspec.yaml
index ddcbc45..7d000ed 100644
--- a/pkg/status_file/pubspec.yaml
+++ b/pkg/status_file/pubspec.yaml
@@ -1,12 +1,11 @@
 name: status_file
-author: Dart Team <misc@dartlang.org>
-description: Parses status files.
-homepage: http://www.dartlang.org
-#environment:
-#  sdk: '>=1.0.0 <2.0.0'
+# This package is not intended to be published.
+publish_to: none
+
 dependencies:
   path: "^1.4.0"
   args: "^0.13.7"
+
 dev_dependencies:
   expect:
     path: ../expect

pkg/status_file/test/repo_status_files_test.dart

diff --git a/pkg/status_file/test/repo_status_files_test.dart b/pkg/status_file/test/repo_status_files_test.dart
index ce57c42..8aacb64 100644
--- a/pkg/status_file/test/repo_status_files_test.dart
+++ b/pkg/status_file/test/repo_status_files_test.dart
@@ -7,7 +7,6 @@
 import 'dart:io';
 
 import 'package:expect/expect.dart';
-import 'package:path/path.dart' as p;
 import 'package:status_file/status_file.dart';
 
 final Uri repoRoot = Platform.script.resolve("../../../");