commit 9043e5be449fa3fa63c378a41ae7f61638b69fbd
author Ryan Macnak <rmacnak@google.com> Fri Jan 25 18:03:30 2019 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Fri Jan 25 18:03:30 2019 +0000
tree 8fc9ec0479fd6d215baf450d035f15d04909c7d9
parent 27760001f5d36ab027b4ce1fbecb245331bd2402

[vm, gc] Remove --gc_at_alloc.

Change-Id: Ied987c5fb0389432474a6ef8ee62ed7089c9e672
Reviewed-on: https://dart-review.googlesource.com/c/91142
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>

runtime/vm/flag_list.h

diff --git a/runtime/vm/flag_list.h b/runtime/vm/flag_list.h
index 401a296..36ececa 100644
--- a/runtime/vm/flag_list.h
+++ b/runtime/vm/flag_list.h
@@ -96,7 +96,6 @@
     "Don't optimize away static field initialization")                         \
   C(force_clone_compiler_objects, false, false, bool, false,                   \
     "Force cloning of objects needed in compiler (ICData and Field).")         \
-  R(gc_at_alloc, false, bool, false, "GC at every allocation.")                \
   P(getter_setter_ratio, int, 13,                                              \
     "Ratio of getter/setter usage used for double field unboxing heuristics")  \
   P(guess_icdata_cid, bool, true,                                              \

runtime/vm/heap/scavenger.cc

diff --git a/runtime/vm/heap/scavenger.cc b/runtime/vm/heap/scavenger.cc
index 01e2df4..1fa8678 100644
--- a/runtime/vm/heap/scavenger.cc
+++ b/runtime/vm/heap/scavenger.cc
@@ -602,13 +602,7 @@
   if (!FLAG_support_service) {
     return;
   }
-  ObjectIdRing* ring = isolate->object_id_ring();
-  if (ring == NULL) {
-    // --gc_at_alloc can get us here before the ring has been initialized.
-    ASSERT(FLAG_gc_at_alloc);
-    return;
-  }
-  ring->VisitPointers(visitor);
+  isolate->object_id_ring()->VisitPointers(visitor);
 #endif  // !PRODUCT
 }
 

runtime/vm/heap/scavenger.h

diff --git a/runtime/vm/heap/scavenger.h b/runtime/vm/heap/scavenger.h
index 412395d..e6b7eab 100644
--- a/runtime/vm/heap/scavenger.h
+++ b/runtime/vm/heap/scavenger.h
@@ -148,12 +148,6 @@
     ASSERT(heap_ != Dart::vm_isolate()->heap());
     ASSERT(thread->IsMutatorThread());
     ASSERT(thread->isolate()->IsMutatorThreadScheduled());
-#if defined(DEBUG)
-    if (FLAG_gc_at_alloc) {
-      ASSERT(!scavenging_);
-      Scavenge();
-    }
-#endif
     uword top = thread->top();
     uword end = thread->end();
     uword result = top;