| commit | 8f4d4391e10bd3a03c25517dd3965e992556c196 | [log] [tgz] |
|---|---|---|
| author | Sigmund Cherem <sigmund@google.com> | Thu Oct 26 20:52:19 2023 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Oct 26 20:52:19 2023 +0000 |
| tree | 80692cc886af13b441fd56113f0109bf6bdb9953 | |
| parent | cbc21d2738e75671aeec2e0d3e670c8138d3cc5b [diff] |
[web] delete file_sample_api_test - a flaky and obsolete test. This test has non-deterministic failures (rate 30% on mac, 10% on linux and windows) caused likely by a data-race ([example log][1]). The test has a write to set the contents of a file, and a corresponding read. The error makes it appear as if the read occurred before the write completed. This API is part of the [createWriter][2] proposal, which was abandoned early on (almost a decade ago) and documented as deprecated. As a result I believe this test is providing coverage for obsolete functionality. In fact, the API for the `write` returns void and appears synchronous, but my guess is that it is not. There is no API to ensure the write completes as far as I know. An alternative here would be to use timers to add a significant delay between the operations. It is also worth noting that the [requestFileSystem][3] API to access the FileSystem (used here and in the fileapi tests) is also deprecated and not supported in firefox or safari. Given the flakiness issue and the fact that this API is already deprecated, I'm not really seeing the value in keeping the test. [1]: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8767600632278735009/+/u/test_results/ignored_flaky_test_failure_logs [2]: https://developer.mozilla.org/en-US/docs/Web/API/FileSystemFileEntry/createWriter [3]: https://developer.mozilla.org/en-US/docs/Web/API/Window/requestFileSystem Change-Id: I92ad6399218c6a17cfa029a99b99afcfadde0035 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332282 Reviewed-by: Srujan Gaddam <srujzs@google.com> Commit-Queue: Sigmund Cherem <sigmund@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.