)]}'
{
  "commit": "8f4d4391e10bd3a03c25517dd3965e992556c196",
  "tree": "80692cc886af13b441fd56113f0109bf6bdb9953",
  "parents": [
    "cbc21d2738e75671aeec2e0d3e670c8138d3cc5b"
  ],
  "author": {
    "name": "Sigmund Cherem",
    "email": "sigmund@google.com",
    "time": "Thu Oct 26 20:52:19 2023 +0000"
  },
  "committer": {
    "name": "Commit Queue",
    "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Thu Oct 26 20:52:19 2023 +0000"
  },
  "message": "[web] delete file_sample_api_test - a flaky and obsolete test.\n\nThis test has non-deterministic failures (rate 30% on mac, 10% on linux\nand windows) caused likely by a data-race ([example log][1]). The test\nhas a write to set the contents of a file, and a corresponding read. The\nerror makes it appear as if the read occurred before the write\ncompleted.\n\nThis API is part of the [createWriter][2] proposal, which was abandoned\nearly on (almost a decade ago) and documented as deprecated. As a result\nI believe this test is providing coverage for obsolete functionality.\nIn fact, the API for the `write` returns void and appears synchronous,\nbut my guess is that it is not. There is no API to ensure the write\ncompletes as far as I know. An alternative here would be to use timers\nto add a significant delay between the operations.\n\nIt is also worth noting that the [requestFileSystem][3] API to access\nthe FileSystem (used here and in the fileapi tests) is also deprecated\nand not supported in firefox or safari.\n\nGiven the flakiness issue and the fact that this API is already\ndeprecated, I\u0027m not really seeing the value in keeping the test.\n\n[1]: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8767600632278735009/+/u/test_results/ignored_flaky_test_failure_logs\n[2]: https://developer.mozilla.org/en-US/docs/Web/API/FileSystemFileEntry/createWriter\n[3]: https://developer.mozilla.org/en-US/docs/Web/API/Window/requestFileSystem\n\nChange-Id: I92ad6399218c6a17cfa029a99b99afcfadde0035\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/332282\nReviewed-by: Srujan Gaddam \u003csrujzs@google.com\u003e\nCommit-Queue: Sigmund Cherem \u003csigmund@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "delete",
      "old_id": "59f693061f900106bc760808733ed5d9485f9b1e",
      "old_mode": 33188,
      "old_path": "tests/lib/html/file_sample_test.dart",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "99c8213cd2e950c997c98832c8ceb606c11b889f",
      "old_mode": 33188,
      "old_path": "tests/lib_2/html/file_sample_test.dart",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    }
  ]
}