commit 8c439c7e841d04d2f05b963fe54457be526ac3d0
author Martin Kustermann <kustermann@google.com> Fri Jan 25 10:25:18 2019 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Fri Jan 25 10:25:18 2019 +0000
tree 0a46484ee732ac57cbe5aba546b715d752dac118
parent 89347169c715d39e5d3e6ae588cd2bdcbb875492

[VM/AOT] Turn bare instructions on by default

Issue https://github.com/dart-lang/sdk/issues/33274

Change-Id: I44850d5906143a53d6b1872eb729364c3a509f9a
Reviewed-on: https://dart-review.googlesource.com/c/91060
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>

runtime/vm/flag_list.h

diff --git a/runtime/vm/flag_list.h b/runtime/vm/flag_list.h
index 95001e4..ea449f3 100644
--- a/runtime/vm/flag_list.h
+++ b/runtime/vm/flag_list.h
@@ -156,7 +156,7 @@
   P(reorder_basic_blocks, bool, true, "Reorder basic blocks")                  \
   C(stress_async_stacks, false, false, bool, false,                            \
     "Stress test async stack traces")                                          \
-  P(use_bare_instructions, bool, false, "Enable bare instructions mode.")      \
+  P(use_bare_instructions, bool, true, "Enable bare instructions mode.")       \
   R(support_disassembler, false, bool, true, "Support the disassembler.")      \
   R(support_il_printer, false, bool, true, "Support the IL printer.")          \
   C(support_reload, false, false, bool, true, "Support isolate reload.")       \

tools/bots/test_matrix.json

diff --git a/tools/bots/test_matrix.json b/tools/bots/test_matrix.json
index 715ce52..9a9323e 100644
--- a/tools/bots/test_matrix.json
+++ b/tools/bots/test_matrix.json
@@ -274,13 +274,13 @@
       "options": {
         "vm-options": ["--no-enable-malloc-hooks"]
     }},
-    "dartkp-bare-linux-(debug|release)-x64": {
+    "dartkp-no-bare-linux-(debug|release)-x64": {
       "options": {
-        "vm-options": ["--no-enable-malloc-hooks", "--use-bare-instructions"]
+        "vm-options": ["--no-enable-malloc-hooks", "--no-use-bare-instructions"]
     }},
-    "dartkp-bare-linux-(debug|release)-(simarm|simarm64)": {
+    "dartkp-no-bare-linux-(debug|release)-(simarm|simarm64)": {
       "options": {
-        "vm-options": ["--no-enable-malloc-hooks", "--use-bare-instructions"],
+        "vm-options": ["--no-enable-malloc-hooks", "--no-use-bare-instructions"],
         "use-blobs": true
     }},
     "dartk-(linux|mac)-(debug|release)-(ia32|x64)": { },
@@ -552,7 +552,7 @@
         {
           "name": "vm tests",
           "arguments": [
-            "-ndartkp-bare-${system}-${mode}-${arch}"
+            "-ndartkp-no-bare-${system}-${mode}-${arch}"
           ],
           "fileset": "vm-kernel",
           "shards": 10